Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190702170228.GA4404@avx2>
In-Reply-To: <20190702170228.GA4404@avx2>
From:   Matteo Croce <mcroce@redhat.com>
Date:   Tue, 2 Jul 2019 19:21:33 +0200
Message-ID: <CAGnkfhxPhHxmNFCMHj8QTYKtLi08O8C5-6Qua8zRz4FX=8g+pw@mail.gmail.com>
Subject: Re: [PATCH] proc/sysctl: add shared variables for range check
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Aaron Tomlin <atomlin@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 2, 2019 at 7:13 PM Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > -static long zero;
> >  static long long_max = LONG_MAX;
> >
> >  struct ctl_table epoll_table[] = {
> > @@ -301,7 +300,7 @@ struct ctl_table epoll_table[] = {
> >                 .maxlen         = sizeof(max_user_watches),
> >                 .mode           = 0644,
> >                 .proc_handler   = proc_doulongvec_minmax,
> > -               .extra1         = &zero,
> > +               .extra1         = SYSCTL_ZERO,
> >                 .extra2         = &long_max,
>
> This looks wrong: proc_doulongvec_minmax() expects "long"s.
> The whole patch needs rechecking.
>
> > +/* shared constants to be used in various sysctls */
> > +const =======>int<========== sysctl_vals[] = { 0, 1, INT_MAX };
> > +EXPORT_SYMBOL(sysctl_vals);

Yes, you're right, that chunk must be dropped.
Anyway I've checked the patch, this was the only long field touched.

Regards,
-- 
Matteo Croce
per aspera ad upstream