Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp146732ybi; Tue, 2 Jul 2019 17:59:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqxp3PVn4QSEdxkQD9gg7NHwfCC5w1gR6fh9g+uAtfRZfjp2zit5OS0TulkkfTnT0OBUcwbP X-Received: by 2002:a63:6ecf:: with SMTP id j198mr33470318pgc.437.1562115576347; Tue, 02 Jul 2019 17:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562115576; cv=none; d=google.com; s=arc-20160816; b=P9+OgCGvlPEMzrl5pcRTSDMef1mzZ1Lxsok7Ah3eA63Ktm+JKIH5MTNOMCFZE+waxE fazN3GC2xaoqxmQVrdtw4SHDw/mlbJtCnOBXYqGk/sS1izL7DCfU+s520h9L5Rxvs5U3 NylMh/KI0cYiqEFX5dM4kPNLfbZyjDzBLNWsiY1WjffmMZvieCJXwf5UUTOp60shIO6d uRE0AyN8NlVRvt37oe6rSlBIz6/kX7p9lWWauhW06b9xEhfG0e5rq3azJ0a0B2cEm0+W IACsqh5xxO3KKBaaHA7BY7HRViSSDdK+l/HcVXSRYnMOtwspgOw/GQabYdkdac1kL+C3 4gUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=TCrBHpvs2bjlY0tZQ78kB/teoCTIaxox5gIgv2Zg7MM=; b=xMhIwS4ji5IIU8+RkW1heRbo4Nsxa2t7rhxc4ZyR26CeZ7d5UNqYDptQWslTG99acZ /CE+1ALm27rulF+ohTg2Gj9l4+iCC7Lc8UaR2q4OL9q4iefp2f78OzBKauNtiOG4dSB8 rUHQ4fGjfurWjiYW1OpgsuB//jYNW7VOigO53Fo4joT3obLUCtHWc6K+jfREhCaGHZqu 6C1XjbADIAl9T6hzNejUPUVYGSbzROyKvHbK7arXRWVtLAhu/QRN7T81L0VokYsGu+vw H9cJdzjnyWuYC0WTjULS5laJ4c/dpXe221j1Zv1YZNdw7jn9e+Ho59VXUsyCIVhBEyNz mbmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=CuI2IgTX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v13si346239pfe.217.2019.07.02.17.59.21; Tue, 02 Jul 2019 17:59:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=CuI2IgTX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727309AbfGCA7C (ORCPT + 99 others); Tue, 2 Jul 2019 20:59:02 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:37699 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727082AbfGCA7C (ORCPT ); Tue, 2 Jul 2019 20:59:02 -0400 Received: by mail-oi1-f193.google.com with SMTP id t76so608769oih.4; Tue, 02 Jul 2019 17:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TCrBHpvs2bjlY0tZQ78kB/teoCTIaxox5gIgv2Zg7MM=; b=CuI2IgTXX842IlAyxReyqFM1sRgD7KsYh/dPgH6QAHgmHFKOPh7/a3W6pU8NOrWD0i r0HgT9QAhB3P0L/SWdmy2QahcMIkNdOT9sM4bcNQi4Ow67paIGHcnPZqpW4yB3lDIPYr 3LvXJK+WTzqu0K9DtXHI7rFi97IFGrcgRoSResKlOVMBTEYfPmMfxpIT9k+/4uJ1yP8z HPI5nCrJ5EzIiMBe7xemYcyUYwvaQdSLLELy1yUsDPMaZfgnz3HGUWHwT8mgyNVshEBb ruxaz1jL4/BjMVUXqdAUlRklzGjyHeKoZ/I+J8ZcWABIvPw0KHcl3yLKYqpM3asVZDIp CZgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TCrBHpvs2bjlY0tZQ78kB/teoCTIaxox5gIgv2Zg7MM=; b=GtqPsYVqQG1GIEcfbhyCT37s4m+muGPBuAoyKX1PSDtJ6bN2ikU4lVR8UXCm+ykZaP 2QzN9ej9gcxfUsr04h9DxVk7qDVdyEZp6SWDu6q9HUjr7CRhF3R+ggO1coEn1beSEZlR AHV1+2yA64iG9GqRVSDrYryTsMH0OqCEMVrpzUQ/zYOEPzaE1fmb/6UAwIbw3gV9KWoe qZodJN1i/BoLSxwX2Y4KUNyeRz8JhbY/2voj/76Bv9ne2xKpPeu1ia0zprr/OEFKj+pd yFHDrnpWJsNB3btb4Gixb1af99K9nZfyspv+bJM75XOPxcBbPdbVFdjqC6mieSWXGsMw NY5g== X-Gm-Message-State: APjAAAVheCBvlaZjxSL0ddNQFfeRDe9ZW0lzpNCnxhNxzJIhyzPkElGH KgLQPuIdzm1ttGagJeYVVVHttDYCsLp/BO3uFf+ymcX5 X-Received: by 2002:aca:4306:: with SMTP id q6mr4696022oia.39.1562109386381; Tue, 02 Jul 2019 16:16:26 -0700 (PDT) MIME-Version: 1.0 References: <20190701091258.3870-1-narmstrong@baylibre.com> <20190701091258.3870-5-narmstrong@baylibre.com> In-Reply-To: <20190701091258.3870-5-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Wed, 3 Jul 2019 01:16:15 +0200 Message-ID: Subject: Re: [RFC/RFT v3 04/14] clk: meson: eeclk: add setup callback To: Neil Armstrong Cc: jbrunet@baylibre.com, khilman@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, amergnat@baylibre.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Cc Alexandre Mergnat On Mon, Jul 1, 2019 at 11:13 AM Neil Armstrong wrote: > > Add a setup() callback in the eeclk structure, to call an optional > call() function at end of eeclk probe to setup clocks. > > It's used for the G12A clock controller to setup the CPU clock notifiers. > > Signed-off-by: Neil Armstrong this will probably work fine, but I want do double check first are we planning to get rid of meson-eeclk (mid-term)? Alex has some patches to get rid of all these IN_PREFIX logic. I'm asking because if we want to get rid of meson-eeclk it may be the time to do so now to have less logic to migrate later on Martin