Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190702075819.34787-1-walken@google.com> <20190702075819.34787-4-walken@google.com>
 <20190702115225.GB3419@hirez.programming.kicks-ass.net>
In-Reply-To: <20190702115225.GB3419@hirez.programming.kicks-ass.net>
From:   Michel Lespinasse <walken@google.com>
Date:   Tue, 2 Jul 2019 18:12:20 -0700
Message-ID: <CANN689HTCisvT-Pcj9koPZ85b7OY3mOBc8S3X2-eZiVWGhwmqg@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] augmented rbtree: rework the RB_DECLARE_CALLBACKS
 macro definition
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Davidlohr Bueso <dave@stgolabs.net>,
        David Howells <dhowells@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 2, 2019 at 4:52 AM Peter Zijlstra <peterz@infradead.org> wrote:
> > - Reorder the RB_DECLARE_CALLBACKS macro arguments, following the
> >   style of the INTERVAL_TREE_DEFINE macro, so that RBSTATIC and RBNAME
> >   are passed last.
>
> That's, IMO, a weird change. C has storage type and name first, why
> would you want to put that last. If anything, change
> INTERVAL_TREE_DEFINE().

Makes sense, will do. I'll have to make it a v3 of the patchset
because RB_DECLARE_CALLBACKS_MAX was introduced with the opposite
argument order. Oh well, no big deal.

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.