Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp159668ybi; Tue, 2 Jul 2019 18:13:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyF/xGnTQaZ7EtZLJ3quyXt/KR8YMXunN6ESQZuOYznAwM3RPyAtnNPF7c7I0BJ3qc0YYI8 X-Received: by 2002:a17:90a:bd8c:: with SMTP id z12mr8949344pjr.60.1562116423188; Tue, 02 Jul 2019 18:13:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562116423; cv=none; d=google.com; s=arc-20160816; b=Sfy2nZEqbaIhHsRRseIS/meV/JiMwVAVuSzKZiPxSLO7MXBy282mhC0v5wN9bi9jZd /K6NPi2iDOUOrRZnn4C3fPjYLvhAHAvUHqKmKwd7x8oqoYfmwZTSaVD4/VLjTUL9+RLK vPcCQ5qbJsiadlUyIJXNURXdaHxlEhIfAeR6NUstwoaf5LWKRLo4FGK9Ha/s3fduG4+i CLLqI0jSOdx8eRZ87TWUhSHZB2YNBrG8Z5+h1HfbzKjp/KfM5pZW9kASykHIBCzxWETp VVE/5F9/TzsH0Z1qv66BSG4/br/Z44LuEzq4rpU1ha+6WM4R4lVRrYteicwoaKX87Fsm ojdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=gmn4/gRjuuSlk+8UerSlSJop90toIZ+cMx1MNCYSm7o=; b=wDcNUhpsps4mpswsMIjxUNOsvVRIHU7/3WUje2CkSDndw0to5viTAKpYMjiDy90+aD 4FJBUi52ZXroQsbBeVWlafh+lpSsbRDQbnm3ZEWxR85ozmYopX+ThPGtRSozIq83KXNh TXZOzbErWcY4wzve/NPv6hzCOodjt0GaKECR+Er1AQOsCAgVeXdsGxmlE6g1YfpDiLGg XPF6WXOsrOWsCYianp07LbvQNRI5fffqjJeICpfQDq1Yzhd+TS6VyzFe8UrQyOdOwGAo y0MK5GWFHUYbC0FiCAaHTGvb6XsYYIH4kSIsqN8skmeIG8/qd2/QzmZIK5OrGWsy2SaV zSxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RBa6CBZo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p15si424244plr.255.2019.07.02.18.13.27; Tue, 02 Jul 2019 18:13:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RBa6CBZo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727299AbfGCBNF (ORCPT + 99 others); Tue, 2 Jul 2019 21:13:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:57308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbfGCBNF (ORCPT ); Tue, 2 Jul 2019 21:13:05 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED1AE218CA; Tue, 2 Jul 2019 21:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562103221; bh=7BKwrn5ZR0EvyKBoBdw71Sjqy+1SUbMyW6AzU7/ufH4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RBa6CBZoD/h1b3spSkXt/s5mk4/LF71sNM0q6jPS2dnne68logM7RJmnQeYqnoPlk We4S37hoCXN1vJ/SylpXLdidWn8wQovBsN3zWD/thJwRlA5V0kPWzkSRUxdgTRtCMR lCSW1e94ZmkPHXhQYrDUGU4rHNsLYjp0UCC4jn8o= Date: Tue, 2 Jul 2019 14:33:40 -0700 From: Andrew Morton To: Waiman Long Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Alexander Viro , Jonathan Corbet , Luis Chamberlain , Kees Cook , Johannes Weiner , Michal Hocko , Vladimir Davydov , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Roman Gushchin , Shakeel Butt , Andrea Arcangeli Subject: Re: [PATCH] mm, slab: Extend slab/shrink to shrink all the memcg caches Message-Id: <20190702143340.715f771192721f60de1699d7@linux-foundation.org> In-Reply-To: <78879b79-1b8f-cdfd-d4fa-610afe5e5d48@redhat.com> References: <20190702183730.14461-1-longman@redhat.com> <20190702130318.39d187dc27dbdd9267788165@linux-foundation.org> <78879b79-1b8f-cdfd-d4fa-610afe5e5d48@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Jul 2019 16:44:24 -0400 Waiman Long wrote: > On 7/2/19 4:03 PM, Andrew Morton wrote: > > On Tue, 2 Jul 2019 14:37:30 -0400 Waiman Long wro= te: > > > >> Currently, a value of '1" is written to /sys/kernel/slab//shrink > >> file to shrink the slab by flushing all the per-cpu slabs and free > >> slabs in partial lists. This applies only to the root caches, though. > >> > >> Extends this capability by shrinking all the child memcg caches and > >> the root cache when a value of '2' is written to the shrink sysfs file. > > Why? > > > > Please fully describe the value of the proposed feature to or users.=20 > > Always. >=20 > Sure. Essentially, the sysfs shrink interface is not complete. It allows > the root cache to be shrunk, but not any of the memcg caches.=A0 But that doesn't describe anything of value. Who wants to use this, and why? How will it be used? What are the use-cases?