Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] module: add usage links when calling ref_module func
To:     Jessica Yu <jeyu@kernel.org>
CC:     <rusty@rustcorp.com.au>, <kay.sievers@vrfy.org>,
        <clabbe.montjoie@gmail.com>, <linux-kernel@vger.kernel.org>,
        "wangxiaogang (F)" <wangxiaogang3@huawei.com>,
        "Zhoukang (A)" <zhoukang7@huawei.com>,
        Mingfangsen <mingfangsen@huawei.com>
References: <8d7aa8b1-73a2-db7a-82c8-06917eddf235@huawei.com>
 <20190701135556.GA25484@linux-8ccs>
From:   Zhiqiang Liu <liuzhiqiang26@huawei.com>
Message-ID: <4473a66b-4aee-1d22-aec8-9d6bceb5b303@huawei.com>
Date:   Wed, 3 Jul 2019 09:28:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <20190701135556.GA25484@linux-8ccs>
Content-Type: text/plain; charset="gb18030"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/7/1 21:55, Jessica Yu wrote:
> +++ Zhiqiang Liu [28/06/19 20:32 +0800]:
>> From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>>
>> Problem: Users can call ref_module func in their modules to construct
>> relationships with other modules. However, the holders
>> '/sys/module/<mod-name>/holders' of the target module donot include
>> the users` module. So lsmod command misses detailed info of 'Used by'.
>>
>> Here, we will add usage link of a to b's holder_dir.
>>
>> Fixes: 9bea7f239 ("module: fix bne2 "gave up waiting for init of module libcrc32c")
> 
> I think we can drop this tag; it doesn't fix a bug specifically
> introduced by that particular commit.
> 
Thanks for your reply.
I will remove the Fixes tag in v2 patch.

>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>> ---
>> kernel/module.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/kernel/module.c b/kernel/module.c
>> index 80c7c09584cf..11c6aff37b1f 100644
>> --- a/kernel/module.c
>> +++ b/kernel/module.c
>> @@ -871,6 +871,11 @@ int ref_module(struct module *a, struct module *b)
>> ?0?2?0?2?0?2?0?2?0?2?0?2?0?2 module_put(b);
>> ?0?2?0?2?0?2?0?2?0?2?0?2?0?2 return err;
>> ?0?2?0?2?0?2?0?2}
>> +
>> +?0?2?0?2?0?2 err = sysfs_create_link(b->holders_dir, &a->mkobj.kobj, a->name);
>> +?0?2?0?2?0?2 if (err)
>> +?0?2?0?2?0?2?0?2?0?2?0?2?0?2 return err;
> 
> We need to fix the error handling here - the module_use struct
> allocated in the call to add_module_usage() needs to be freed (you
> could just modify add_module_usage() to return the use pointer so that
> it's easier to free from within ref_module()), module_put() needs to
> be called, and the use struct should be removed from its respective
> lists (see module_unload_free()).
> 
Thanks again for your advice.
We will modify add_module_usage func to return the use pointer as your suggestion.
In the error handling, We will call module_put() and call list_del() to remove the use.

> Thanks,
> 
> Jessica
> 
> 
> .
>