Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 03 Jul 2019 10:32:08 +0200
Message-ID: <s5hzhlvmsc7.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Wasko, Michal" <michal.wasko@linux.intel.com>
Cc:     nick83ola <nick83ola@gmail.com>, alsa-devel@alsa-project.org,
        info@jensverwiebe.de,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        Richard Fontana <rfontana@redhat.com>,
        Jussi Laako <jussi@sonarnerd.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Allison Randal <allison@lohutok.net>
Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: fix Line6 Helix audio format rates
In-Reply-To: <38462424-4e2b-bdbd-f7cc-ea94385924e0@linux.intel.com>
References: <20190702004439.30131-1-nick83ola@gmail.com>
        <s5hlfxg4i4r.wl-tiwai@suse.de>
        <4181a467-5332-c256-5124-513a0343ec70@linux.intel.com>
        <s5ha7dw4egd.wl-tiwai@suse.de>
        <CABPh3UMttE1s7oNt0-JLNm2N3wxb-JXBTLzMYZM42ENiy9NC9Q@mail.gmail.com>
        <s5h36jno8vb.wl-tiwai@suse.de>
        <38462424-4e2b-bdbd-f7cc-ea94385924e0@linux.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 03 Jul 2019 10:26:31 +0200,
Wasko, Michal wrote:
> 
> >> My idea is that if line6 in the future fixes their code (they are quite active
> >> on the helix line) the call will not fail and we get a proper device without
> >> quirks.
> >> But If the driver fail to get the clock this settings works as a "failsafe"
> >> and get the device working.
> >> I also tried to contact their support but they don't care a lot about Linux
> >> for now :-(
> > The fallback might be good, but I'm not sure whether there are many
> > devices that hit the same problem.  If we encounter more, let's try to
> > make it as a fallback.
> > thanks,
> >
> > Takashi
> Since there is a chance that the issue will be addressed in USB device FW
> thanthe fallback mechanism will make sense. It would cover eventual future
> scenario withdevices that will have the issue fixed.

Fair enough.  Let's handle it as fallback, then.


thanks,

Takashi