Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 3 Jul 2019 11:17:04 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Song liwei <liwei.song@windriver.com>
cc:     linux-kernel@vger.kernel.org,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Will Deacon <will@kernel.org>, Borislav Petkov <bp@suse.de>,
        Kulkarni <Ganapatrao.Kulkarni@cavium.com>,
        Guo Ren <ren_guo@c-sky.com>, Joseph Lo <josephl@nvidia.com>,
        Hoan Tran <Hoan@os.amperecomputing.com>,
        Anju T Sudhakar <anju@linux.vnet.ibm.com>,
        Rafael J <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] x86/microcode, cpuhotplug: move microcode hotplug callback
 after cpu teardown
In-Reply-To: <1562143728-78052-1-git-send-email-liwei.song@windriver.com>
Message-ID: <alpine.DEB.2.21.1907031114490.1802@nanos.tec.linutronix.de>
References: <1562143728-78052-1-git-send-email-liwei.song@windriver.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 3 Jul 2019, Song liwei wrote:

> After CPUHP_TEARDOWN_CPU callback was invoked, the context will become
> atomic and IRQ disabled, while mc_cpu_down_prep will called
> kernfs_find_and_get_ns which will try to acquire mutext lock which may
> sleep.
> 
> Adjust CPUHP_AP_MICROCODE_LOADER callback function run before
> CPUHP_TEARDOWN_CPU to fix this bug.

That's just wrong and reintroduces the bug which was fixed with that commit
as perf will access a non existing MSR which is brought in by the micro
code update.

Aside of that the mutex issue _is_ fixed in rc7 already:

 5423f5ce5ca4 ("x86/microcode: Fix the microcode load on CPU hotplug for real")

Thanks,

	tglx