Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp726243ybi; Wed, 3 Jul 2019 03:44:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqzrlhqwt+QgmHNJnwTHA138Gu73eeMijkhxX+ISRnohr+SVCxwGdcHk7l5Gb9YmFTOyHGzo X-Received: by 2002:a63:d755:: with SMTP id w21mr36782381pgi.311.1562150652308; Wed, 03 Jul 2019 03:44:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562150652; cv=none; d=google.com; s=arc-20160816; b=AU+9mxm/5Fzjm70KjRs0AuVY62y8qCUpm1AZ9ofKf0Laj5p9UnMehuepL436P5Luh0 dehvipH6+8GYr2tv/fRGzfRO3ulBlA9qR6Fl9gDdQPtTE4FrKCQ/MvcvdFAG84N0w8cW KWP3U3M6xtylYgrP0xylKx5my7x7FecY4/zUWDOiMXfl7Tz+qrkqc9pwlyRnzy6jUjad EfSmOPE+Tu/eaS6PTGEKoOX16m+jxhQ7ed0Fgt42sCkYiEETvqieeI2yWv1pXZUCnSaT TS37ElAoIgBOSpU5Y3yGWQTlry9ovzPipMxus2ULLGpmHELU9gOrUjO7REOnALUfL57k TByw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2JMW71Dfk1XqRwhWsoZlir4dIBNhyCLLIlJMI0D17fo=; b=bIAQ5ONuy7845izM6S+ckz1uvym9fHF1X5RAI07LVX12oiERunx9HxgX+25LAcd9O5 F9LCITwklDv4xuh/BLD8XBYnuZ/8MplIIkuO7+IBzW78QLGO32Lo0sg2YN2rIgieOkCy 8NzB41aBlOtHZYB7qg/Ew+RWIGs0iSLVGASHxy/th5QsUVY2Sjrnal4HdFBZ/4TvYa7w 8GFes4OjvuO09yLke/BeIkNDL8i9TWEcTDRaJzmsO/rj9z20GRaIlUYVva5ssxPhQhl4 wcX2DaqyjfL368YyRPSO/Lm1xskg60k2/5rBNttsVmO7rq0KrCFte95TjYT9KMXEkbXr rDwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zJuASnOI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n190si1970901pgn.362.2019.07.03.03.43.57; Wed, 03 Jul 2019 03:44:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zJuASnOI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727028AbfGCKnd (ORCPT + 99 others); Wed, 3 Jul 2019 06:43:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:59678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbfGCKnd (ORCPT ); Wed, 3 Jul 2019 06:43:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0292D218A0; Wed, 3 Jul 2019 10:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562150612; bh=rtDwzSnNcOQGNWFdCc1Bop63mTOkGYGEB+m7tqXFlm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zJuASnOIQ3MT+bbM+Sz0FCw91geKA+AuC/9yWArXtPEJXVCPJ+lqQh1JUR4d/wtPU lXB+SORru4EBjr/Q+Dy+4LF6VSUuUaaFw2XtYeJ/Bt3dH9Pc3pJnX7w+sRP1qJEGNY CotA44WUtO/aOvwVu0vfu6T3E1frrWEhgG+rSYJk= Date: Wed, 3 Jul 2019 12:43:30 +0200 From: Greg KH To: Daniel Borkmann Cc: Markus Elfring , bpf@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] bpf: Replace a seq_printf() call by seq_puts() in btf_enum_seq_show() Message-ID: <20190703104330.GA8931@kroah.com> References: <93898abe-9a7d-0c64-0856-094b62e07ba2@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 03, 2019 at 12:09:51PM +0200, Daniel Borkmann wrote: > On 07/02/2019 07:13 PM, Markus Elfring wrote: > > From: Markus Elfring > > Date: Tue, 2 Jul 2019 19:04:08 +0200 > > > > A string which did not contain a data format specification should be put > > into a sequence. Thus use the corresponding function “seq_puts”. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > The code is fine as is, I'm not applying this. Just a heads up, this person/bot is in my kill-file, making it easier to ignore crazy things like this. I recommend it for other maintainers to also do as well. thanks, greg k-h