Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <felipe.balbi@linux.intel.com>
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-stable <stable@vger.kernel.org>,
        "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] usb: dwc2: use a longer AHB idle timeout in dwc2_core_reset()
In-Reply-To: <CAFBinCD1qj8sNXOK2Pcbz1MAcdvwywPSxQeERNVpmNw=Gmz=Vw@mail.gmail.com>
References: <20190620175022.29348-1-martin.blumenstingl@googlemail.com> <a7647aea-b3e6-b785-8476-1851f50beff1@synopsys.com> <CAFBinCDDyG_CxW+PB_OrUXfy-aDKSoewC2OyCfGh18N=omSgcQ@mail.gmail.com> <CAFBinCD1qj8sNXOK2Pcbz1MAcdvwywPSxQeERNVpmNw=Gmz=Vw@mail.gmail.com>
Date:   Wed, 03 Jul 2019 14:38:07 +0300
Message-ID: <87d0ir4acg.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi,

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> On Mon, Jul 1, 2019 at 7:54 PM Martin Blumenstingl
> <martin.blumenstingl@googlemail.com> wrote:
>>
>> On Mon, Jun 24, 2019 at 7:41 AM Minas Harutyunyan
>> <Minas.Harutyunyan@synopsys.com> wrote:
>> >
>> > On 6/20/2019 9:51 PM, Martin Blumenstingl wrote:
>> > > Use a 10000us AHB idle timeout in dwc2_core_reset() and make it
>> > > consistent with the other "wait for AHB master IDLE state" ocurrences.
>> > >
>> > > This fixes a problem for me where dwc2 would not want to initialize when
>> > > updating to 4.19 on a MIPS Lantiq VRX200 SoC. dwc2 worked fine with
>> > > 4.14.
>> > > Testing on my board shows that it takes 180us until AHB master IDLE
>> > > state is signalled. The very old vendor driver for this SoC (ifxhcd)
>> > > used a 1 second timeout.
>> > > Use the same timeout that is used everywhere when polling for
>> > > GRSTCTL_AHBIDLE instead of using a timeout that "works for one board"
>> > > (180us in my case) to have consistent behavior across the dwc2 driver.
>> > >
>> > > Cc: linux-stable <stable@vger.kernel.org> # 4.19+
>> > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> > > ---
>> >
>> > Acked-by: Minas Harutyunyan <hminas@synopsys.com>
>> thank you for reviewing this!
>>
>> is there any chance we can get this fix into Linux 5.3? I know that
>> it's too late for 5.2 so I'm fine with skipping that.
> thank you Felipe for queuing this for v5.3!
> for reference, this patch is now in the usb-for-v5.3-part2 tag: [0]
>
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=usb-for-v5.3-part2&id=dfc4fdebc5d62ac4e2fe5428e59b273675515fb2

I'll send pull request soon :-)

-- 
balbi