Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp886593ybi; Wed, 3 Jul 2019 06:11:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEuYnJK0uBCiuurFlrFaPwQ64KCHFzUYoR8khq+c6FXlSVToVxRJ9ckEZ2zFLLjdkh6LXE X-Received: by 2002:a63:f817:: with SMTP id n23mr37412650pgh.35.1562159506300; Wed, 03 Jul 2019 06:11:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562159506; cv=none; d=google.com; s=arc-20160816; b=dZt9QJcv8O59sDn1eMM+wjsiz4f9L+RWJy72p14UwZPx2a42cMq++sUdEh8vKTsuA2 6vAskHBK/R2pT8skzaABPSEaX3dHNHO79k8PFZmFT2MiKTBfXVFUZhS4LQsLkIR8IEvp weWOwLpmkPuRKrxVG7EHzFZzB4F88iw1UtMz/9yrVc1XX4OumqLCW455bv8axbtA8EDB K2K3IHND88bHGP4haH37mO4NJat4lJhchUl6IwhejkkfsPAZLH2nOWjue5Wk8zENG7uB mTYO7ub7wLjhEt5m9LS/xOAYHHtduj/9rsyhSpEJq1AyPQWVb1WQMcoZb/TscxuBn3Nw d2RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=1Bobaa50WXbR9Y4LcY/j1xmyJEA8EpS2B/y8I4HgN8Y=; b=Pmo9Gzd4YNdP+FN7YxStoZGyz/XnELlquf45oowxqvz/k+/WboHfvg+jcagEYYVLUq 9qCFvJfs48jAzAeeOrnIfbx/xia4NdUmeskXUB/K4ObmkPYtmcCyLcAmDOg8vg63aoWJ kJG7f+kMxxObZtaOveBh/4WMoodQK9Hgv42RsP1rsS8mOf0vA3jz5NbIs4MshKhAxsqG ngGi4omFBrlecbojsB8KXfANbDJFj+WmoNgg6RathouSebarX455pQBszqGxmC/CziXr jyZ0G0/Kk900cjfh1b+En3rEnveB3A1Kr73z4LY4+QfBSe0staYlXafWA/owWj5xti7m fdSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=m01HNG6w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w2si2386725pfi.183.2019.07.03.06.11.27; Wed, 03 Jul 2019 06:11:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=m01HNG6w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726924AbfGCNKw (ORCPT + 99 others); Wed, 3 Jul 2019 09:10:52 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34819 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbfGCNKw (ORCPT ); Wed, 3 Jul 2019 09:10:52 -0400 Received: by mail-wr1-f68.google.com with SMTP id c27so2781320wrb.2; Wed, 03 Jul 2019 06:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1Bobaa50WXbR9Y4LcY/j1xmyJEA8EpS2B/y8I4HgN8Y=; b=m01HNG6wrx/reIarGAfsQfArF84e7O4uyXNBjqkc9OOTg8rv7kmLMtGi/FGFpq/IHM LLFm+60f/VkHVa/kdCHMn3Gdk31L0i7zSM8d7O9Yop9simcXDE2BFiTdV5wWl9ApObxn dF3oVE8bQ7aJhpHFPcU+LGNtNDRgbAxjQfMy5gHMowF1EQq5jWLIvX2mz5NOP6Cr5jva WH7a83cBEgSceLeUh7dtKLV7cUNsAVryRJWwIGXFU7WSdK0WzKrsuFiIxA3/ARt4L5p4 5kvXGVYykMG1z5CkyV+VVwmJ2z9YwW1gBVglW86TSqLoXPg99UbW1QKZ/wEPhWppm3xq 72Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Bobaa50WXbR9Y4LcY/j1xmyJEA8EpS2B/y8I4HgN8Y=; b=AEqEQhW8J79qychvVLeQYIvs7ZwWlOQJCVN87SU0wX5b3FN/fsVhTKXbpZi1W7QMGk UdNrRjV6Qh2skfKsT0lnyYCNkrGaPdfzq9mh2QwLfkaPhIyIGSEwOrKgRzNRhl1EvkRv HzsgJZnen8uSjec5PoGcORNgdAG/Shq6InLBRsGSBN8nsi3vvpOQzyMNgR2ThdJ0RJjV zXvLcxbmGKilKLW6q6MYg0C36DwV9p3W2N+VlAKjwQ/VZrKUpu+cTLcY0mSEGMxxCSif tV2AhbIW7MQAzvbvj7vV7DkEA91B4A46D0uLLJgwQhg58b3cSP4O/G9wQTVjoOiexqgm wCEw== X-Gm-Message-State: APjAAAWeiXFCRqMALzTyoQs3zf0ovszVj3IFfOUW+JOrsdngz2LSG1QL YFmpKOOrRCMpl3qfz9WvOsPkoB71sAYPnPwB9tk= X-Received: by 2002:adf:b69a:: with SMTP id j26mr21775717wre.93.1562159449703; Wed, 03 Jul 2019 06:10:49 -0700 (PDT) MIME-Version: 1.0 References: <20190702132353.18632-1-andradanciu1997@gmail.com> <9ea5109f8645c3f27a9e350c5f9b2d4c@www.akkea.ca> In-Reply-To: <9ea5109f8645c3f27a9e350c5f9b2d4c@www.akkea.ca> From: Daniel Baluta Date: Wed, 3 Jul 2019 16:10:38 +0300 Message-ID: Subject: Re: [PATCH v3] arm64: dts: imx8mq: Add sai3 and sai6 nodes To: Angus Ainslie Cc: Andra Danciu , Shawn Guo , Rob Herring , Mark Rutland , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , Lucas Stach , Abel Vesa , Anson Huang , andrew.smirnov@gmail.com, Carlo Caione , =?UTF-8?Q?Guido_G=C3=BCnther?= , Devicetree List , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 3, 2019 at 4:01 PM Angus Ainslie wrote: > > Hi Andra, > > I tried this out on linux-next and I'm not able to record or play sound. > > I also added the sai2 entry to test out our devkit and get a PCM timeout > with that. Hi Angus, There are still lots of SAI patches that need to be upstream. Me and Andra will be working on that over this summer. > > On 2019-07-02 07:23, Andra Danciu wrote: > > SAI3 and SAI6 nodes are used to connect to an external codec. > > They have 1 Tx and 1 Rx dataline. > > > > Cc: Daniel Baluta > > Signed-off-by: Andra Danciu > > --- > > Changes since v2: > > - removed multiple new lines > > > > Changes since v1: > > - Added sai3 node because we need it to enable audio on pico-pi-8m > > - Added commit description > > > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 29 > > +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > index d09b808eff87..736cf81b695e 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > @@ -278,6 +278,20 @@ > > #size-cells = <1>; > > ranges = <0x30000000 0x30000000 0x400000>; > > > > + sai6: sai@30030000 { > > + compatible = "fsl,imx8mq-sai", > > I don't find this compatible string in sound/soc/fsl/fsl_sai.c. Aren't > the registers at a different offset from "fsl,imx6sx-sai". Yes, you are right on this. We are trying to slowly push all our internal-tree patches to mainline. Obviously, with started with low hanging fruits, DTS nodes and small SAI fixes. Soon, we will start to send patches for SAI IP ipgrade for imx8. > > How is this supposed to work ? > For the moment it won't work unless we will upstream all our SAI internal patches. But we will get there hopefully this summer. Thanks, Daniel.