Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751065AbVK3LGS (ORCPT ); Wed, 30 Nov 2005 06:06:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751158AbVK3LGS (ORCPT ); Wed, 30 Nov 2005 06:06:18 -0500 Received: from scrub.xs4all.nl ([194.109.195.176]:8908 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S1751065AbVK3LGS (ORCPT ); Wed, 30 Nov 2005 06:06:18 -0500 Date: Wed, 30 Nov 2005 12:06:17 +0100 (CET) From: Roman Zippel X-X-Sender: roman@scrub.home To: Oleg Nesterov cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/9] timer locking optimization In-Reply-To: <438D8BC0.1993824F@tv-sign.ru> Message-ID: References: <438C5057.A54AFA83@tv-sign.ru> <438D8BC0.1993824F@tv-sign.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 23 Hi, On Wed, 30 Nov 2005, Oleg Nesterov wrote: > Another problem. __mode_timer() does: > > if (timer_pending(timer)) { > detach_timer(timer, 0); > > Note that 'clear_pending' parameter == 0. This means that detach_timer() > will remove the timer from list, but won't clear 'pending' status. So > this will crash after 'goto restart' (or in case of concurrent del_timer()). I just noticed this too. I'll drop the patch and I'll also change the second patch. Thanks for looking into this. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/