Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 02/30] powerpc: Use kmemdup rather than duplicating its
 implementation
To:     Fuqian Huang <huangfq.daxian@gmail.com>
Cc:     linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
        linuxppc-dev@lists.ozlabs.org
References: <20190703131327.24762-1-huangfq.daxian@gmail.com>
From:   Christophe Leroy <christophe.leroy@c-s.fr>
Message-ID: <80d073af-f7b5-6c9d-de51-110f14d15380@c-s.fr>
Date:   Wed, 3 Jul 2019 15:19:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20190703131327.24762-1-huangfq.daxian@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Le 03/07/2019 à 15:13, Fuqian Huang a écrit :
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memset, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.

s/memset/memcpy/

> 
> Add an allocation failure check.

Shouldn't this be in another patch ?

Christophe

> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
>   arch/powerpc/platforms/pseries/dlpar.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
> index 437a74173db2..20fe7b79e09e 100644
> --- a/arch/powerpc/platforms/pseries/dlpar.c
> +++ b/arch/powerpc/platforms/pseries/dlpar.c
> @@ -383,9 +383,10 @@ void queue_hotplug_event(struct pseries_hp_errorlog *hp_errlog)
>   	struct pseries_hp_work *work;
>   	struct pseries_hp_errorlog *hp_errlog_copy;
>   
> -	hp_errlog_copy = kmalloc(sizeof(struct pseries_hp_errorlog),
> +	hp_errlog_copy = kmemdup(hp_errlog, sizeof(struct pseries_hp_errorlog),
>   				 GFP_KERNEL);
> -	memcpy(hp_errlog_copy, hp_errlog, sizeof(struct pseries_hp_errorlog));
> +	if (!hp_errlog_copy)
> +		return;
>   
>   	work = kmalloc(sizeof(struct pseries_hp_work), GFP_KERNEL);
>   	if (work) {
>