Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp920516ybi; Wed, 3 Jul 2019 06:40:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqws+EqcDIJ1FSRs3Ic9akmdEElabSzfqiCvya6PLFHPu36DYm+MebAqcDWEHpE29WuFS67I X-Received: by 2002:a17:902:934a:: with SMTP id g10mr43375717plp.18.1562161252949; Wed, 03 Jul 2019 06:40:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562161252; cv=none; d=google.com; s=arc-20160816; b=Kuvia4BsAE5lMze4xyipWPbnvEGjaadX5MUUaP353emq+VwlFAUcxQZfwpgsd+d8WU gHjcvIPAyj6m4tDpRvgmvp+BB7hi4NuHJqDCUhwMupV40oZSoY5UHsVXFMgYpiJDKam+ ZrQKelfEoma03O42K195lgQorKdjA6UyN1oA3EgXgy2I7DU8vd9nVE0gUfzUYbk9Jdpz vKDQvWuKpua2AICX2e9Aw0MgkvfRUIxgW1j4vVvQs2ftS3mcY+dVPRY6QH+V0NVwDQn2 1roNZQREL1J2VVA9VUAko5q9z93RCAjzB1SomarJUrh/7eG4wgsAk0OFS4P67Q18l+JB BHtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=T7/0Ek9Sv+iwKTmZHt6k7Kbbq1mUDtNW+JzOsnRi4kk=; b=bhAdUjodcZX30Pp5J1/q39gbktRa4oqhPFx0JX89a3mqehbp6p1pJM9+e3GAZ8pMMO z9opILNYLYTWwavMSgRV0ZW93lN5lzTrTi9YMn9JjRNGn1EbYm4R/byn/IR2p1i7/m1f eKLN2x0kVdsnLwTwnmp4XsIy874z1bCy0az4pMk8RkhbeE8vMBqoLOdOStjAlg3TwHZ4 8CXURgCWKx/0L+MmxENzHv4BsVWTk1M+6RC2Y8k+n6ac+QhE4nYzQtK5OmKCfZcFavP0 hriDl7vYVL9MZ3AoySAVKOlt1w5FRQTfq6cUhRGvk+ekOirL9ROEpDlO9ENO478c6EXg JWDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si2406845pff.263.2019.07.03.06.40.36; Wed, 03 Jul 2019 06:40:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbfGCNkD (ORCPT + 99 others); Wed, 3 Jul 2019 09:40:03 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:38420 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbfGCNkD (ORCPT ); Wed, 3 Jul 2019 09:40:03 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hifUJ-0000ZL-GZ; Wed, 03 Jul 2019 15:39:55 +0200 Message-ID: Subject: Re: [PATCH net-next v6 07/15] ethtool: support for netlink notifications From: Johannes Berg To: Michal Kubecek , David Miller , netdev@vger.kernel.org Cc: Jakub Kicinski , Jiri Pirko , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , linux-kernel@vger.kernel.org Date: Wed, 03 Jul 2019 15:39:54 +0200 In-Reply-To: <4dcac81783de8686edefa262a1db75f9e961b123.1562067622.git.mkubecek@suse.cz> References: <4dcac81783de8686edefa262a1db75f9e961b123.1562067622.git.mkubecek@suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-07-02 at 13:50 +0200, Michal Kubecek wrote: > > +static bool ethnl_ok __read_mostly; Not sure it makes a big difference, but it could probably be __ro_after_init instead? johannes