Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1014275ybi; Wed, 3 Jul 2019 08:06:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzd00OUNB7ajsnqqWti25V+bRPLuZhaPKLhGEshSgqAEkmzV1zniIY0xbT1UTOWMFdcWmXi X-Received: by 2002:a17:902:2bc5:: with SMTP id l63mr44337979plb.30.1562166375740; Wed, 03 Jul 2019 08:06:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562166375; cv=none; d=google.com; s=arc-20160816; b=BIMM5+KKxHIzR5jQfkQhmm91zGaokGIEYuX7O84wyf3IZzG+6xECMM6jcsseqTbk80 w1jiEuusLmePJzbzOE9DMzjKy7GgFuLASwwct65FzI9KNILrtChutffXM9V6vIm6hGVV Py3txv4z1Q7VpSmgRK0cPyx9KrNHj1wGHI76KitazIWjOw+kqCVNVlhNeTxCVybt8zAu w1kbu1gKjkrxmbb3LlsHiuuY29OtuRZWLslRlxh/toCelyNLMhwuTQ5kq8/jYH0OYZ2y 4pdzjSbpM0N2oxmwkJnGV1bodgaqFoPmIFEysjmyUmdYEmEXSTUctWFDOhPsaXpvrMIt 8ZKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=fbYyKX4Z+wqWUHR+ceiURDgiKzYyOByTnHLkoBGNQR0=; b=D4uxBJXprZxb5mFfhOQyzBJaSgtYhB3nq6B1hkfaWe/lewbtU31EVmXE33qielE3Dw i5lrhmvTc003h+Rr1vqEBCdrXnrzNiEyr3bBui8nm1MwlePSHBFJWz0eOq6cnYwjMINX wJh6nKHwlS4bhhbsj2EkCFWKJBk70PoHrumyEvgjwD8cki0JXUqaqtLn1hmgc2I+dY2y LhbxrKhVI6vaaIaxxVt2vEFaaykNiTx+TvDuWB/NeQqJYjKjPDwmXcWiO3xYkREw0AZK BjNNCNuyXIgLiQKVVhS1cg4Ym/AjLMGVYJy+j66I3/HDcL9X/82MAYcSJ8ZMBIFAJ7qg 0OzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g31si2536214plb.241.2019.07.03.08.05.55; Wed, 03 Jul 2019 08:06:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726997AbfGCPFc (ORCPT + 99 others); Wed, 3 Jul 2019 11:05:32 -0400 Received: from www62.your-server.de ([213.133.104.62]:53904 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726675AbfGCPFa (ORCPT ); Wed, 3 Jul 2019 11:05:30 -0400 Received: from [78.46.172.2] (helo=sslproxy05.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1higon-0001dI-N1; Wed, 03 Jul 2019 17:05:09 +0200 Received: from [178.193.45.231] (helo=linux.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1higon-0007PN-GI; Wed, 03 Jul 2019 17:05:09 +0200 Subject: Re: [PATCH bpf v6 0/2] xdp: fix hang while unregistering device bound to xdp socket To: Ilya Maximets , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, xdp-newbies@vger.kernel.org, "David S. Miller" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Jonathan Lemon , Jakub Kicinski References: <20190628080407.30354-1-i.maximets@samsung.com> From: Daniel Borkmann Message-ID: Date: Wed, 3 Jul 2019 17:05:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190628080407.30354-1-i.maximets@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.3/25499/Wed Jul 3 10:03:10 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/28/2019 10:04 AM, Ilya Maximets wrote: > Version 6: > > * Better names for socket state. > > Version 5: > > * Fixed incorrect handling of rtnl_lock. > > Version 4: > > * 'xdp_umem_clear_dev' exposed to be used while unregistering. > * Added XDP socket state to track if resources already unbinded. > * Splitted in two fixes. > > Version 3: > > * Declaration lines ordered from longest to shortest. > * Checking of event type moved to the top to avoid unnecessary > locking. > > Version 2: > > * Completely re-implemented using netdev event handler. > > Ilya Maximets (2): > xdp: hold device for umem regardless of zero-copy mode > xdp: fix hang while unregistering device bound to xdp socket > > include/net/xdp_sock.h | 5 +++ > net/xdp/xdp_umem.c | 21 +++++----- > net/xdp/xdp_umem.h | 1 + > net/xdp/xsk.c | 87 ++++++++++++++++++++++++++++++++++++------ > 4 files changed, 93 insertions(+), 21 deletions(-) > Applied, thanks!