Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 3 Jul 2019 18:35:00 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Antti Palosaari <crope@iki.fi>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Brad Love <brad@nextdimension.cc>
Subject: Re: [PATCH v1] media: si2168: Refactor command setup code
Message-ID: <20190703163500.GF22408@latitude>
References: <6a8f9a5b-2e88-8c26-440b-76af0d91eda6@free.fr>
 <20190702095109.GC22408@latitude>
 <6a644c94-f979-b656-472b-c7fe9303e08c@free.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="+KJYzRxRHjYqLGl5"
Content-Disposition: inline
In-Reply-To: <6a644c94-f979-b656-472b-c7fe9303e08c@free.fr>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--+KJYzRxRHjYqLGl5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi again,

On Wed, Jul 03, 2019 at 02:47:59PM +0200, Marc Gonzalez wrote:
> On 02/07/2019 11:51, Jonathan Neusch=C3=A4fer wrote:
> > On Mon, Jul 01, 2019 at 01:44:09PM +0200, Marc Gonzalez wrote:
[...]
> >>  static const struct dvb_frontend_ops si2168_ops;
> >> =20
> >> +#define CMD_SETUP(cmd, __args, __rlen) do {	\
> >> +	int wlen =3D sizeof(__args) - 1;		\
> >> +	memcpy(cmd.args, __args, wlen);		\
> >> +	cmd.wlen =3D wlen; cmd.rlen =3D __rlen;	\
> >> +} while (0)
> >=20
> > It would be nice for casual readers to have a little comment here, that
> > explains (briefly) what this macro does, and what the arguments mean,
> > and their types.
>=20
> Just a bit of background.
>=20
> A macro is required /at some point/ because arrays "decay" into pointers
> when used as function arguments.

*nod*

[ I should have been more specific: By "here" I meant at that spot in
  the code, and by casual readers I mostly meant casual readers of the
  code once it's merged. ]

> Come to think of it, I'm really not a fan of "large" macro functions.
> I'll outline a different option in v2.

The v2 approach looks nicer to me, thanks.

> > Why cmd rather than __cmd? This seems inconsistent.
>=20
> Note: I hate using underscores in macro argument names, but they clashed
> with the struct field names. There was no such clash for 'cmd'.

Hmm, ok.

> > The wlen local variable can be avoided by a bit of suffling:
> >=20
> > 	#define CMD_SETUP(cmd, __args, __rlen) do {	\
> > 		cmd.rlen =3D __rlen;			\
> > 		cmd.wlen =3D sizeof(__args) - 1;		\
> > 		memcpy(cmd.args, __args, cmd.wlen);	\
> > 	} while (0)
>=20
> Do you think it is important to avoid a local variable?

Not exactly important, but wlen would be another name that can collide
with the name spaces of the functions where the macro is used and
trigger -Wshadow.


Greetings,
Jonathan Neusch=C3=A4fer

--+KJYzRxRHjYqLGl5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl0c2QoACgkQCDBEmo7z
X9vqIQ/9F6XYipBcpNCZYGQUrxmhVQAySFpGgnw4LXFN/OS1wwFkzq3dOEMQgCnf
4hd7FvCcWKWnPOgMnbo9LcX6YulRh3WY44n4HF6d0HF3wGF91zvCn6Z7a9HieFhO
BvrUfELL9/t1gC93iEnXeLBvz5gVUkLQfsHgIxlOuZ6/zej2ZiWvDh9c0jBix23Q
0DqHwEWjjWkVTwm5m4G/pSzjAEUGoVjBK8r8Y8QhrDEm7y/FyZZXbdcXxka6OMYP
Ij6PEb7SH8oLCuSpttWvjVVb0mcH6HY6frhpkO140iZ3gLe4THBbkPA+NCDIWN/c
hx68+4FbnTif+k0Ds/hWRMmAzGvA2EnEi/cFOOSv3RWXh8D1op9p6PO/T5Urq22I
hxgYhUeFTdONMRFPqjCP0nnmZQ1Bzf5TKFPKBjrGnX7tYy1F9QIDFcM7FXRz/7Fx
zPO96Sh4/XiK6Cg+bL1rVAge8g85sjyIZgJpL9eF8lXmCqCoLXeI33nOuDaS5LnA
N0tbwzXJAqM2aTF+nV+JMebRNFqzGnuA3bQgwx283fAO1P5jOOgqxNC+Y7jIO0lG
3yEe07IqpP1d2z5Q5y8/XwBIpEYOThX64PH+09TpM3mmMkBqNy/WpSRnjtr/XuKK
c0Fa4E4EDkwIDOmPmf7Nj6/MUny4Jmgo6vfa0Dlb4YSyV/VSMks=
=gWpD
-----END PGP SIGNATURE-----

--+KJYzRxRHjYqLGl5--