Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1132562ybi; Wed, 3 Jul 2019 10:02:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqfbSnkOwwvRqJohNIojenqCQPKwJs5eOWIB4P55LEtmf8UR6TIjjGB7cPvUjFGVG74Ph1 X-Received: by 2002:a17:902:9a95:: with SMTP id w21mr43102744plp.126.1562173376950; Wed, 03 Jul 2019 10:02:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562173376; cv=none; d=google.com; s=arc-20160816; b=vyRb0FP1tzcka8w1Pv+nw6zCgxZY0/EX4dsnanffzwGLfj6coepjuLpTdBTJPLEMWO eAr2v0mlvJP2bTnrjbJwATs+QF+qLvupj7zSR9/GjGAjZdzwW8oU9ybxv8QgXkNf/Shh 9V9C8dxXpdfkKkWZIbprfo7ynvJ5X6+WzUXxCok+j2o3lKlojYprlO9pTbWFYFkHReZ8 BhlaLT5kCzoywtPCvK4EoPFuqXC/GyXji9tsGKD9YoyCRqB+F0z26i1ThYQEpf2QhAkT nJZ1OEKeKzPm/paEx2ZuPAVbyTk7zFtMrC9W20b998gnH4YyWZPk4iu8Sxtdkivcz5u2 izmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=GTnb3wOq3N88WSvvVUf/IfvNsBRFmYHBdDSAW0StD1A=; b=Y3YorZUcNvbB25K4YV439O+Q/lJUe4oRL9Q47JKPVHPz7hZU9ZE8HJGZMxQ/vH3Fn+ owe0jxo4MprMpBqNIJMO7WXUcopD7tr6GoZ+aqAqodjGqFCKMkKHg00InUrtVE3Ji/ft NCTnc00Uc1aDSfXOAyyP0d63hzADJSN2y7akq91OPpNqD0oS2ZtcXM+cPzGd4SrHFHAF g7QYSTwdYMMF24G+MtZ1O9hKsjWgZtMY+uWiUAK2rd6hp2WEG08M6R1/l1wUxrsJavpk 7ej94HyawTwHmBX+IGyoD4k5L36+6pd9vS+MHVfD8jv7TwBHpjjAWUlguvIF8UkyNV6r 8FcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 205si2832342pge.295.2019.07.03.10.02.37; Wed, 03 Jul 2019 10:02:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727188AbfGCRB5 (ORCPT + 99 others); Wed, 3 Jul 2019 13:01:57 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:50896 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727179AbfGCRB4 (ORCPT ); Wed, 3 Jul 2019 13:01:56 -0400 Received: by mail-wm1-f65.google.com with SMTP id n9so2971063wmi.0 for ; Wed, 03 Jul 2019 10:01:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GTnb3wOq3N88WSvvVUf/IfvNsBRFmYHBdDSAW0StD1A=; b=rtwhJ9SmuBdFFn7JAiYuC99kWvTxS6d7WXEyNg1pR34kC60VIvOf1B1Rww6eV+C3jh nLlw4Dqmgr4LkfzolVrbkdXDUq3V0J61cHvgQpKQpxTNCP5vorP1s6VPE/9XbeWX0my1 av6vQmxB0zw3IiTzwPNhzwCfBSNJfsH7Xvzwq+1MjwS5cJ7NgVLoPe5k8HzNrDji7mso /ZOJ8d48q9kjcbtgcJow7iLT/QHqI2KxTsM678pBRqOHVFSKtbn0fb1u7JTcPBR2/JmD gmozjueJpR+qo9qAp91P5dF8rm7ysd2mI53WQCwwSgQkP5q9hlOwaT5Q7Cx85MbKX0Hl 1JHA== X-Gm-Message-State: APjAAAUTkEN8U3U3J38ogpNmoog8LDZYa4PsSGDnT6PTo9fsirlUaDpE 32Il90OXl9OfH4MZzsbh1bA3sGT4 X-Received: by 2002:a1c:4184:: with SMTP id o126mr8571665wma.68.1562173314889; Wed, 03 Jul 2019 10:01:54 -0700 (PDT) Received: from green.intra.ispras.ru (bran.ispras.ru. [83.149.199.196]) by smtp.googlemail.com with ESMTPSA id e7sm3990330wrt.94.2019.07.03.10.01.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Jul 2019 10:01:54 -0700 (PDT) From: Denis Efremov To: =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= Cc: Denis Efremov , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/client: remove the exporting of drm_client_close Date: Wed, 3 Jul 2019 20:01:50 +0300 Message-Id: <20190703170150.32548-1-efremov@linux.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function drm_client_close is declared as static and marked as EXPORT_SYMBOL. It's a bit confusing for an internal function to be exported. The area of visibility for such function is its .c file and all other modules. Other *.c files of the same module can't use it, despite all other modules can. Relying on the fact that this is the internal function and it's not a crucial part of the API, the patch removes the EXPORT_SYMBOL marking of drm_client_close. Signed-off-by: Denis Efremov --- drivers/gpu/drm/drm_client.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index f20d1dda3961..bffc87ac21c7 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -60,7 +60,6 @@ static void drm_client_close(struct drm_client_dev *client) drm_file_free(client->file); } -EXPORT_SYMBOL(drm_client_close); /** * drm_client_init - Initialise a DRM client -- 2.21.0