Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1156504ybi; Wed, 3 Jul 2019 10:27:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwK9yCl52KvtXWhqsQJiiAA094u+G0cYRHET16booFdWtHmCO1WYz8pe/ppk3XAtJg3mWQD X-Received: by 2002:a17:902:b187:: with SMTP id s7mr43292569plr.309.1562174827408; Wed, 03 Jul 2019 10:27:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562174827; cv=none; d=google.com; s=arc-20160816; b=byQSJwAT4Vb32kX63e6478mcvrnvjWppA3v7y3x4o53SY2jiPaUmiR1P4ybP74FT6x ItV4iemgIXYlgU9hoM4LeJRk4nWCb5nboxWP4ez3AGgM0aU2cDVTvQ+S/bGPMWG4VHD5 wLSKfangDZsQzxPJ8aXbJdwVsLPng2IizaONtIOAXyVm/GymEcUUoZ8JCp5oje1U2t3z aB8y1BmtOkRPYwjSiWy6h9Z9vjri0cFzlMixkMwwvBgM+iehTTfsYsVmhoH91MXNc5cf FCo5KWc50mVV/BktFTyw1w5/O9YlLcX5w7iUf2bpVw0qLiqmDk+Upn4GD74oiN3CgxBM W4ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BIyzHdZ+CuqP8piIV4g0ILBWvZ6l2nEpy5LUb9H2XoM=; b=j1rn+nGp0oAK+CRqIP1uLms9/XgCLyjAlCW7D7QQt8rdmZ7a8t9FTN2ZfJIY9AjyFo mJ5B9ynY39El3VKEUVLZjJWRCWRBwG9PO+Azjc+YgNWyjT8vYBFLbq01OZTi6+kd/ONH nr2b+pHbgstrMk7bE7YH+6zeVio2Sfiu7cgSdNCo+ibTnmlReZwhjzltMwGw30Z3P8rJ uBtK7OqTSH8d/9VIW8F21qJAUwk+YA4nzlCDKtRrIorEff+TL/FLIsK2QFCwDP//wgIP hq65wZW0uFBDM2xQUpwDVwOHrN5gzxJZJDsgiH2OLj+pEIBApb17j/nMO6Y/HqaMD9z5 o13A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AYS+IKyn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g18si2862884pgk.477.2019.07.03.10.26.52; Wed, 03 Jul 2019 10:27:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AYS+IKyn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727129AbfGCR0A (ORCPT + 99 others); Wed, 3 Jul 2019 13:26:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:42156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726430AbfGCRZ6 (ORCPT ); Wed, 3 Jul 2019 13:25:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81E4F21882; Wed, 3 Jul 2019 17:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562174757; bh=lxYyl+A0IAWOAgK39yCb7roVLH41SjjTjki8EWP00eU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AYS+IKynoqAI09h6gRL3UJ/G0xw0wi1J+6dLoAWNGeSHZ9ZhVsJq9HQsEjxFIBc6h mqlFTaYlaATTtrTAzhsBnjEDooptMmZbgIxeZSJ7L3Ck25jNhLl8HfybTvHna6oVXa dO/adH/MvoDphKrg4N7Ap7c27bI5uHwTuMkpJHck= Date: Wed, 3 Jul 2019 19:25:54 +0200 From: Greg KH To: jeyentam Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices. Message-ID: <20190703172554.GA27719@kroah.com> References: <20190702032323.28967-1-je.yen.tam@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190702032323.28967-1-je.yen.tam@ni.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 01, 2019 at 08:23:23PM -0700, jeyentam wrote: > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices. > > Signed-off-by: jeyentam > --- > drivers/tty/serial/8250/8250_pci.c | 879 +++++++++++++++++++---------- > 1 file changed, 582 insertions(+), 297 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c > index df41397de478..0a711b895b33 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -1,10 +1,10 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Probe module for 8250/16550-type PCI serial ports. > + * Probe module for 8250/16550-type PCI serial ports. > * > - * Based on drivers/char/serial.c, by Linus Torvalds, Theodore Ts'o. > + * Based on drivers/char/serial.c, by Linus Torvalds, Theodore Ts'o. > * > - * Copyright (C) 2001 Russell King, All Rights Reserved. > + * Copyright (C) 2001 Russell King, All Rights Reserved. > */ Why are you changing comments for no reason?