Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1292136ybi; Wed, 3 Jul 2019 13:00:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDJDASn5Q+XzEu3sxaAWxj4mlONOOLiQZ75Pma8x9QrZXi4trLGEkdjmdA0L2cFjwOGm/D X-Received: by 2002:a63:fd0d:: with SMTP id d13mr40105950pgh.423.1562184023410; Wed, 03 Jul 2019 13:00:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562184023; cv=none; d=google.com; s=arc-20160816; b=N5eLHj/kheoRS/XmFBBBpVzl0m1tSZItBprcxj4cP6qWBL3k+Lr+J0F5PGon2sWKnH RPbj98BPQKsSBHwRheCPD99aJdVOUmRe1uJuUxxHqs4Ny1ASvZAQ6nuBsv34+WgG+qG/ jv61i918SgN3fLWkHOC4Ditsexqxdxg5a3MV4v+DFU2PBzuJ+oq1evavdtMs2SGPipqR iQbKFg6YCvFexJof1CeuM8Js291RObiF4+uzMXZpyCdYo2yVuKq4d72J71YMrjmLUhYq 1BZ2Om1aUKiwB2LYC7wxliGzrY2b04Wq7+jhTk8WZPKK0wowKvLVAvtsqO/mLxNnS3lj APkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qyhSe/m3iFJvhjLT7XfiQp9W/+VrvcZY//8DOqO8pmo=; b=z6aUIW9pwOMO7LnaR7r5yeminKUot4U8zu4T1LmI6AwrG4o8dKEGVLBUNYc9a6CQ3H tt/r7jupirIbLTqB7nzCjvUZ5MFCVMjkhNtxwYVXhTvtAujkJNW25oqqfZ5XvqVM+KQv V0CMRUqZRdl28q7KLWoJJJiBar0VkyAj9kkZFcRiS3rZcGyShRxrOsYiBuRt8gA0OgUo 0kwxTRuEJzKipQpQWJWyH03VGgFClP7/zBnx4sfzemtf0beRajEPnqOJIoO3+lUDqrgd 6cL6h5HBI2sOGsQxhMEUau32RV8FM6Lii2Y51HFepZHd9t8UeOIgBHXhB6ZSxC7TQKQa kaYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0glXAHEj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d37si2986977pla.288.2019.07.03.13.00.08; Wed, 03 Jul 2019 13:00:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0glXAHEj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbfGCT7L (ORCPT + 99 others); Wed, 3 Jul 2019 15:59:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:53362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbfGCT7K (ORCPT ); Wed, 3 Jul 2019 15:59:10 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4626421882; Wed, 3 Jul 2019 19:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562183949; bh=qyhSe/m3iFJvhjLT7XfiQp9W/+VrvcZY//8DOqO8pmo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0glXAHEjYCtRfQ5vgverCgt8lN8cjzwgJLzBScTnm4hRnf3ldUCMP9XpFA1splffi FUkETyP3XuHqUK65m2k+5kiWTWSssP+CnWNZof/ivMKz5ZY8Po2X7RIVmE7ls0wVs6 09PoNq5qg00FHriHOQZGjufA54HkOAKIB7mNepRk= Date: Wed, 3 Jul 2019 15:59:08 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Fei Yang , Sam Protsenko , Felipe Balbi , linux-usb@vger.kernel.org, Felipe Balbi , John Stultz Subject: Re: [PATCH 4.19 26/72] usb: dwc3: gadget: use num_trbs when skipping TRBs on ->dequeue() Message-ID: <20190703195908.GC2733@sasha-vm> References: <20190702080124.564652899@linuxfoundation.org> <20190702080126.031346654@linuxfoundation.org> <20190703020312.GS11506@sasha-vm> <20190703072012.GA3033@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190703072012.GA3033@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 03, 2019 at 09:20:12AM +0200, Greg Kroah-Hartman wrote: >On Tue, Jul 02, 2019 at 10:03:12PM -0400, Sasha Levin wrote: >> On Tue, Jul 02, 2019 at 10:01:27AM +0200, Greg Kroah-Hartman wrote: >> > commit c3acd59014148470dc58519870fbc779785b4bf7 upstream >> > >> > Now that we track how many TRBs a request uses, it's easier to skip >> > over them in case of a call to usb_ep_dequeue(). Let's do so and >> > simplify the code a bit. >> > >> > Cc: Fei Yang >> > Cc: Sam Protsenko >> > Cc: Felipe Balbi >> > Cc: linux-usb@vger.kernel.org >> > Cc: stable@vger.kernel.org # 4.19.y >> > Signed-off-by: Felipe Balbi >> > (cherry picked from commit c3acd59014148470dc58519870fbc779785b4bf7) >> > Signed-off-by: John Stultz >> > Signed-off-by: Sasha Levin >> >> This one has an upstream fix: c7152763f02e05567da27462b2277a554e507c89 >> ("usb: dwc3: Reset num_trbs after skipping"). > >You were the one who queued this series up :) Indeed, and I'm actually quite happy about this. Even though I goofed up and didn't notice the fix when it got queued up, the automation we have in place to catch these cases worked and we were able to get the fix in as well before release. -- Thanks, Sasha