Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1736380ybi; Wed, 3 Jul 2019 22:30:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqxGcNaJhm/nWqKuuCuXytwBL0HCo0Dm4AfOG928/jYzldfA8pLCMGr5kMvYKYs1b3qQy1gU X-Received: by 2002:a17:90a:3086:: with SMTP id h6mr17754185pjb.14.1562218201422; Wed, 03 Jul 2019 22:30:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562218201; cv=none; d=google.com; s=arc-20160816; b=RUdh/BUXUsbaXI4NPFFH5spieH0LOyBP3UBidyQ2i2cXUUOl2VIAHGVIi7NDacjCWK odCa+gQ0JtN3BT7k4NBgxj8pjm4r+S+tJiK1HYtOcExQkVjSlSFxQQg4XEI5fLD1zAcz YJDcs5OFe6wJrTpw5prCYinC0DitjE0KA6FETXGQRfRcWCD1BeyR0LKxH67oCGIiOFog 3shHaj/0sNHfiCvEUNXSV01HwdrWNiGKlqiZ/eG8/H060uMgX/5jm/+PHlHZIjefwu10 OFYntZcqyNfYNGos1wQpHcf3HduBoLzB+ZugeX/5kIwcnZnyallYM8zuuSl7bQrCUYtm ZRbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=w85uUMonQra/uQD1eSmbmC43o1iLgQAtsQdzjviUSto=; b=PSESl1qIf8gX1K66lcGxJ8zB0hM2aPgxy/AfDs+uJVgmA3iCoEi2kztOvImukcoX75 1ETt5DJavsg6JH6iLGosqpeOZ4U3OSnbq1xPrbdr8lTE9Th6PKAS5NXmxTVS0wlWk7BR VnQWldxwqHUU5ooCiSNAgeEmN+riASU8mGEluZiRPZ5JNIszNpgTP9Gkq+qOZM0qRTOV CsprCJBUGYWxHtzWQp/U9WO0rUHxKP1e2+Dxjx8rc71epI9VVipRBZ918/sNtz4wbd/+ A8NrAljBCpTQHtaI4CNFLauJE/Crb1uCmPkVpbyF+mkVSGM8wF061Aekc1gvJaQ4JSsF OwHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pLn7CV1p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8si4264718pgk.539.2019.07.03.22.29.32; Wed, 03 Jul 2019 22:30:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pLn7CV1p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbfGDF0x (ORCPT + 99 others); Thu, 4 Jul 2019 01:26:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:39568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbfGDF0x (ORCPT ); Thu, 4 Jul 2019 01:26:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E7426218A3; Thu, 4 Jul 2019 05:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562218012; bh=I+0cH+uMT7VJ70KPqMIW9T45sVtfmgYmhLBmxgsq+no=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pLn7CV1p02AUDr60ZlfdxpQ5bkJ8gd6ERqKq4pMX+CjKvnIsgmHtPNGcgQlejITNx NYrdzjP+yqOoe/er9SU58/O+EPX1S24y3KThzgRsDyRl3FzS0RfRVPF4fe7AVvg1qd vD6iQ1lux/9E6IXGm/cgxz7eruZZHPTmQYa6snQE= Date: Thu, 4 Jul 2019 07:26:49 +0200 From: Greg KH To: Yue Hu Cc: devel@driverdev.osuosl.org, yuchao0@huawei.com, linux-kernel@vger.kernel.org, huyue2@yulong.com, linux-erofs@lists.ozlabs.org Subject: Re: [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data() Message-ID: <20190704052649.GA7454@kroah.com> References: <20190702025601.7976-1-zbestahu@gmail.com> <20190703162038.GA31307@kroah.com> <20190704095903.0000565e.zbestahu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190704095903.0000565e.zbestahu@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 04, 2019 at 09:59:03AM +0800, Yue Hu wrote: > On Wed, 3 Jul 2019 18:20:38 +0200 > Greg KH wrote: > > > On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote: > > > From: Yue Hu > > > > > > Already check if ->datamode is supported in read_inode(), no need to check > > > again in the next fill_inline_data() only called by fill_inode(). > > > > > > Signed-off-by: Yue Hu > > > Reviewed-by: Gao Xiang > > > Reviewed-by: Chao Yu > > > --- > > > no change > > > > > > drivers/staging/erofs/inode.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > This is already in my tree, right? > > Seems not, i have received notes about other 2 patches below mergerd: > > ```note1 > This is a note to let you know that I've just added the patch titled > > staging: erofs: don't check special inode layout > > to my staging git tree which can be found at > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > in the staging-next branch. > ``` > > ```note2 > This is a note to let you know that I've just added the patch titled > > staging: erofs: return the error value if fill_inline_data() fails > > to my staging git tree which can be found at > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > in the staging-next branch. > ``` > > No this patch in below link checked: > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/drivers/staging/erofs?h=staging-testing Then if it is not present, it needs to be rebased as it does not apply. Please do so and resend it. thanks, greg k-h