Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Je Yen Tam <je.yen.tam@ni.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Thread-Topic: [EXTERNAL] Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485
 device IDs
Thread-Index: AQHVMXB865RUzFDHYki64KPD1/QjN6a4kdOAgAF0UiA=
Date:   Thu, 4 Jul 2019 06:58:39 +0000
Message-ID: <MN2PR04MB5920BB86A99B1ABF946B2373B7FA0@MN2PR04MB5920.namprd04.prod.outlook.com>
References: <20190703072516.34199-1-je.yen.tam@ni.com>
 <20190703083605.GA8996@kroah.com>
In-Reply-To: <20190703083605.GA8996@kroah.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: ni.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 65ff0b80-6cf0-4ccc-9fc4-08d7004d0b5d
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2019 06:58:39.7862
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: je.yen.tam@ni.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5904
Subject: RE: Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-04_04:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=inbound_policy_notspam policy=inbound_policy score=30
 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=30 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1907040090
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Wed, Jul 03, 2019 at 12:25:16AM -0700, jeyentam wrote:
> > Add NI PXIe-RS232, PXI-RS485 and PXIe-RS485 device IDs.
> >
> > Signed-off-by: jeyentam <je.yen.tam@ni.com>
> > ---
> >  include/linux/pci_ids.h | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
>=20
> You have read the comment at the top of this file, right?  If so, why=20
> are you adding these entries?

Yes, but I think these entries should be added in because the NI-Serial PXI=
=20
(RS232) device IDs already been defined in this file originally, so now I'm=
=20
adding the newly supported NI-Serial PXI (RS485), PXIe (RS232) and PXIe=20
(RS485) device IDs into here as they are the same product.

>=20
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index=20
> > 70e86148cb1e..7fad4794789f 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -1027,7 +1027,9 @@
> >  #define PCI_DEVICE_ID_SUN_TOMATILLO	0xa801
> >  #define PCI_DEVICE_ID_SUN_CASSINI	0xabba
> >
> > +/* NI-Serial Device IDs */
> >  #define PCI_VENDOR_ID_NI		0x1093
>=20
> That's a vendor id, not a serial device id.

Yes, will change it to vendor id.

>=20
> thanks,
>=20
> greg k-h


Thank you.
Regards,
Je Yen Tam
Staff Software Engineer
National Instruments=A0
o=A0=A0 604-3776397
e=A0=A0 je.yen.tam@ni.com