Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2001913ybi; Thu, 4 Jul 2019 03:32:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvecKB4TpqUH1SC+cc1yXXawIwXIWPgn3AZXVbHondmeLREQrH5OUNlfYvXInnyB72zQnD X-Received: by 2002:a17:90a:26ef:: with SMTP id m102mr18613085pje.50.1562236320563; Thu, 04 Jul 2019 03:32:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562236320; cv=none; d=google.com; s=arc-20160816; b=QEOKymIE75KQk+v6ZpFjHPKYP8PShelhMW9Ks2l9SWbdtqYuEhPRMvc0DGhZ6Pg19X V0FPFLQc2eABJ1tJZzOS8JIlM2ktNnjGK0a5MQEpXlNyyoJ6Xe4LwCR0eUF0DV01eyzp et+jaaBL52PnZ+J9ZMfguA0sVm8SyX9sMNJTJHEwgiwFtOpt02I8PEeggVoUXGAe042X 9zLD/fmJr1lNAPmX4gwtQcM8x6V4K027HCUU+WdrjHVu5Kxj+Cf75wVP1U4isVdt1diK W+roiAlR/Ko/YPrpkWKthhEI+s+AXO2l/3CCGFwsTuTJxfO7U3M0OlZ64H6xo3+ctQeX 1SzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=IbO+axQyrwYA7Gru4+vW09zOo13IJDBme8+zmCdlBNA=; b=d5YFNW26V2VWowxMLddcqzbeqsdHEbjmNPsRXRCrulcQimd3d7PeYUhaq8kSeteQat 44/R1nza0YcE6EC+zN2depTyEfZK0QugRe8PbAwx5S5+HAFh5+NPBg4vz6ukY400lfwy SBfr+GILnj1zFv9hS0pDviRahOVcw27W1AnwIrSLGvD/j4qOidB77H3pOVA48KgMOaVv NqgkVAXXXW4hog9vP0jEboZdIJ7jqD+1vPmoH+cjGa83mD/htF+rAibGorEvezFV8csC GEoif0itM1AaKASVryhHzKLb1pGkLc6hFLBYw1vpDaUGZzUlOFRxdimEW2VUU3TR42wX NI9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si5654868pfn.104.2019.07.04.03.31.45; Thu, 04 Jul 2019 03:32:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727546AbfGDKbV (ORCPT + 99 others); Thu, 4 Jul 2019 06:31:21 -0400 Received: from ns.iliad.fr ([212.27.33.1]:45016 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727303AbfGDKbU (ORCPT ); Thu, 4 Jul 2019 06:31:20 -0400 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id 052E7205C8; Thu, 4 Jul 2019 12:31:19 +0200 (CEST) Received: from [192.168.108.49] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id E286A201B0; Thu, 4 Jul 2019 12:31:18 +0200 (CEST) Subject: Re: [PATCH v2] media: si2168: Refactor command setup code To: =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= Cc: Antti Palosaari , Mauro Carvalho Chehab , linux-media , LKML , MSM , Brad Love , Bjorn Andersson References: <20190704101401.GG22408@latitude> From: Marc Gonzalez Message-ID: <2dfb88d8-be2b-c6b6-fe39-6083dd418ccc@free.fr> Date: Thu, 4 Jul 2019 12:31:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190704101401.GG22408@latitude> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Thu Jul 4 12:31:19 2019 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2019 12:14, Jonathan Neuschäfer wrote: > On Thu, Jul 04, 2019 at 11:58:45AM +0200, Marc Gonzalez wrote: >> >From ceb5f687f3f7dab2fb9d5b34408d9cf83a0be228 Mon Sep 17 00:00:00 2001 >> From: Marc Gonzalez >> Date: Mon, 1 Jul 2019 12:58:31 +0200 >> Subject: [PATCH v2] media: si2168: Refactor command setup code >> >> Refactor the command setup code, and let the compiler determine >> the size of each command. >> >> Signed-off-by: Marc Gonzalez > > Reviewed-by: Jonathan Neuschäfer Thanks for the review. I see that I messed up the header, I'll respin a v3, and add your tag. Regards.