Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2075769ybi; Thu, 4 Jul 2019 04:51:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqyoYvzdHFteia2RQ9pmhl5+wNU6Xb4hILrgiv9dijBz1DRWR37U3VIZJ9Bw+7atRcsO1lTz X-Received: by 2002:a17:902:6b07:: with SMTP id o7mr47578501plk.180.1562241068233; Thu, 04 Jul 2019 04:51:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562241068; cv=none; d=google.com; s=arc-20160816; b=SZshjIUcBk0NqVigVRWjnnifG+Xms9/rstmZhew3fgtQxMzYSe5PgCNI4QJpKF8eqZ yxTPEbMXcNeF1Lfuj2i5qqFMBH5Lgly/+y4FRKkGW+HaNA1biZeA9olrt3ayM+5W6QvV KiyqEn4rQbdS3SrOReIebCRjjXrVceUAtUMWwv54oDkn0xCxANOltqOUlbLyMn/oenB/ afpwAxe2BrOYsvSE40DbnbnzFxe4ArRqYwfUnZGPOwf6LAd1oGJVcazW9D/YwKbRxV50 MDqIwJH/avHZeGRs2/Tqye5xajY5FDArbntTKmRsPmse+92EfHAD31Pv/dFS1t3czACP fX6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject; bh=JY/JBnTwAiGW21EU668lx5PsBdCSeJhq2RET8ljqTao=; b=PDtUWGFAKXZ4oj5gcDgmRBdxw/DEp9E5tBbvfL7S+oX+RE1nbmSu24TGoE+0rf2Sbb 3XCzlr1Fig5bClCR2bVlshmGFMoAX4CjPIpP7t3JAPuyn/goAbwcZNWbiqR9pGrcsHcW scyo88xoxgQ9x/IJ5WTeSz9HMpeY0Bi9V/f/cHiWVViwIAW0nWzqllPX53CkiU4r+pk7 Uy1IbVFzefYu11LiL/5ndjQzC9EFl3rnHtMKFq6TGN66hRjRPb/68XDU3pPr6Dr2VZcE 37LLgZC5kzNg/L4T57y5OF834tNEXxhtIpbh5aK9yaLn7o+Q882sQ8EjdqnRGYZLCxEY C31Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e123si5190381pgc.479.2019.07.04.04.50.53; Thu, 04 Jul 2019 04:51:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727695AbfGDLsu (ORCPT + 99 others); Thu, 4 Jul 2019 07:48:50 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:4388 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727669AbfGDLsu (ORCPT ); Thu, 4 Jul 2019 07:48:50 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x64BmjmL116942 for ; Thu, 4 Jul 2019 07:48:49 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2thee260r3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 04 Jul 2019 07:48:48 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 4 Jul 2019 12:48:21 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 4 Jul 2019 12:48:16 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x64BmFsV41812092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Jul 2019 11:48:15 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E0B611C066; Thu, 4 Jul 2019 11:48:15 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1AFEC11C050; Thu, 4 Jul 2019 11:48:13 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.110.72]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 4 Jul 2019 11:48:12 +0000 (GMT) Subject: Re: [PATCH] Revert "tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend()" From: Mimi Zohar To: Roberto Sassu , Jarkko Sakkinen , Michal Suchanek , linux-integrity@vger.kernel.org Cc: Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , James Bottomley , David Howells , Tomas Winkler , Armijn Hemel , Stefan Berger , Jerry Snitselaar , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Date: Thu, 04 Jul 2019 07:48:02 -0400 In-Reply-To: References: <20190701131505.17759-1-msuchanek@suse.de> <8e4cc105b748c5395132b4d3d29d0d9b30a8720c.camel@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19070411-0012-0000-0000-0000032F3A18 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19070411-0013-0000-0000-00002168908F Message-Id: <1562240882.6165.78.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-04_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=747 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907040153 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-07-04 at 13:28 +0200, Roberto Sassu wrote: > On 7/4/2019 12:03 PM, Jarkko Sakkinen wrote: > > On Mon, 2019-07-01 at 15:15 +0200, Michal Suchanek wrote: > >> This reverts commit 0b6cf6b97b7ef1fa3c7fefab0cac897a1c4a3400 to avoid > >> following crash: > > > > Thank you. I think this the right choice for the moment. I fixed > > a trivial checkpatch.pl error and added the mandatory tags. Can > > you check quickly v2 (just posted)? > > > > I already made it available in my master and next. > > Could you please wait few days? I would prefer to fix this issue instead > of reverting the whole patch. Nayna posted a patch late yesterday titled "tpm: fixes uninitialized allocated banks for IBM vtpm driver", which addresses this bug. Mimi