Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2122802ybi; Thu, 4 Jul 2019 05:35:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTTGUgYtd4s2Fsn1C45u3jyl0XFSPHqY0sX68C9D7u514NcYBi3q3uVkmKFXaq8cj2+9GE X-Received: by 2002:a63:6c04:: with SMTP id h4mr12133424pgc.94.1562243707344; Thu, 04 Jul 2019 05:35:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562243707; cv=none; d=google.com; s=arc-20160816; b=AhSpJHjFoEynsFhLQr822pHIFeLqv96ahTdyEPk3FX44mnw++fTWQA3CsX7cCREXfo d6INYUqFBc8XYatoMmKwYzNHnrVTtUTy0sk2lrzCKc5iD3LLsmEz1F5KW7nnyHXS/6dz XsswTeH9knhhCGv3r68d65u/uLOP4xjg2YHdpV6TjWlYy8YddCltTSfcDgqjdik94nWk FAMOd8SDFOmxQKwryaxFb4LBXQWiWhlqa2bgbkdMo9uWzlYUMIIJJsWzd/a/ERH64op3 7woyEUJWWA7/hxYS2eOa4htmqjwCoSBaGyqJcRYRu+zb/e4Cxr1g/KPw81O8ycmPTc/e PglA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WZGgIFqntPiBjka+Oo35Sy0erf1ztfXIu7MoeeCl7sI=; b=wpGydaXxU+RFKZHLml19fyvps9eeiGaEwLmQhDjfHhW1okm0FuoQ6Ynuteym0ggCbY Z6KPsa8e1h4gKwl6Ql4wQxiXECHqhiZ5Y3JLjpUCwd/jFVtlX4ZZZBLpiKRJvjfQIYfq +Yvj0zTfcqfS13vilzSoDdm9X36vPT8bJIuF/zAJvM/W3Bqa5YAseabGh5G8NklW93U2 vDybdoOYBvUWOrMP7gMmzib+U8iLYzMvued2Zbs6pIgB9D4XzpzNL4TmxXwS+szNldko ZqtKTR1vBPqXolyU1NIQ+caMOfVqCBN/DTv5xeBezD8FFHnDpp1C56NcJNUH+aKl657V PEiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=U9w9DXvX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g24si5458751pfi.119.2019.07.04.05.34.52; Thu, 04 Jul 2019 05:35:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=U9w9DXvX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727793AbfGDMeM (ORCPT + 99 others); Thu, 4 Jul 2019 08:34:12 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:44343 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727714AbfGDMeM (ORCPT ); Thu, 4 Jul 2019 08:34:12 -0400 Received: by mail-lf1-f66.google.com with SMTP id r15so4126489lfm.11; Thu, 04 Jul 2019 05:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WZGgIFqntPiBjka+Oo35Sy0erf1ztfXIu7MoeeCl7sI=; b=U9w9DXvX6ZI9Ka2kloHxm/f4bFuu9xySWFoJtdxm/VYD4Rkc+XAKcMy5K7CBhciu02 SEq/+/Pio+BB9Rco4ZaD6BQbo6UwGX6CfbA1orS2o/JIML3G8areymFCYg7SLLSgm3y2 Cnp97gucU6HsG/BSS9GfAu2abg4TzfWCJELRa/XBgL1f/xeIB3En/q4vqN48n5X6v7fy x47DQ9CxjWYjlNCwtb+lMVZAz1Xj+t38c8RSSwnnzhmdHJu6mqPPM6G7fucCRDrfcmjN htaCUlrr8Pu2JHWIcLLuzeYPjlMTFg3a3UkK9gM+OPsHnkqzEMY4VnSl/1mq6NmYB0cV MwFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=WZGgIFqntPiBjka+Oo35Sy0erf1ztfXIu7MoeeCl7sI=; b=anVep3fciviRt4QnTG02L59A3HEUgknfjws8vkkqY765ZbYNB6T1InsRm/kpBcOlVD T+gbDHxCtyK7j1wsKAp4Lkq068MJhe8Cy64gOVqLghaoKXPEwUe+dLZ6UjFmEgye1bEX AehmWzsAUPz508fJw4FINQfqPBXmWhoG9Z066XUXwvIqDhnNE0OEwdQlaY1pZ2CQcGjt 8kuNez7tEPk2tmELCbhppzaxqqy0kgCZSvBHiFZayaQO6HYT7QWldKp7Su28/uGwwj1D xFqih3a4Zati+vVJLktTU98BCmBfAAM0KN4rwsJaM4AmIsBNnRlwiuXRbpeD1rRiP1Ne NYbA== X-Gm-Message-State: APjAAAXVBkqAcYg7FBQZ0u+yAwA/UTpPPfOW0bRWRp1oSS3XkIB7lFkW f9/WHfU2pyV9MwwZILbF6zI= X-Received: by 2002:ac2:4351:: with SMTP id o17mr1633834lfl.100.1562243649805; Thu, 04 Jul 2019 05:34:09 -0700 (PDT) Received: from rric.localdomain (83-233-147-164.cust.bredband2.com. [83.233.147.164]) by smtp.gmail.com with ESMTPSA id b25sm866069lfq.11.2019.07.04.05.34.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jul 2019 05:34:08 -0700 (PDT) Date: Thu, 4 Jul 2019 14:34:00 +0200 From: Robert Richter To: Peter Zijlstra Cc: Jessica Yu , linux-kernel@vger.kernel.org, jpoimboe@redhat.com, jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com, ast@kernel.org, daniel@iogearbox.net, akpm@linux-foundation.org, Steven Rostedt , Ingo Molnar , Martin KaFai Lau , Song Liu , Yonghong Song , Mathieu Desnoyers , "Paul E. McKenney" , "Joel Fernandes (Google)" , Ard Biesheuvel , Thomas Gleixner , oprofile-list@lists.sf.net, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 2/3] module: Fix up module_notifier return values. Message-ID: <20190704123359.jumjke6p7p5r7wbx@rric.localdomain> References: <20190624091843.859714294@infradead.org> <20190624092109.805742823@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190624092109.805742823@infradead.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.06.19 11:18:45, Peter Zijlstra wrote: > While auditing all module notifiers I noticed a whole bunch of fail > wrt the return value. Notifiers have a 'special' return semantics. > > Cc: Robert Richter > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: Martin KaFai Lau > Cc: Song Liu > Cc: Yonghong Song > Cc: Mathieu Desnoyers > Cc: "Paul E. McKenney" > Cc: "Joel Fernandes (Google)" > Cc: Ard Biesheuvel > Cc: Thomas Gleixner > Cc: oprofile-list@lists.sf.net > Cc: linux-kernel@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: bpf@vger.kernel.org > Signed-off-by: Peter Zijlstra (Intel) > --- > drivers/oprofile/buffer_sync.c | 4 ++-- > kernel/module.c | 9 +++++---- > kernel/trace/bpf_trace.c | 8 ++++++-- > kernel/trace/trace.c | 2 +- > kernel/trace/trace_events.c | 2 +- > kernel/trace/trace_printk.c | 4 ++-- > kernel/tracepoint.c | 2 +- > 7 files changed, 18 insertions(+), 13 deletions(-) Reviewed-by: Robert Richter