Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2185496ybi; Thu, 4 Jul 2019 06:31:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzKT9cw8h5/86Y72gyDN1UvxoS3+W7ZBSgupLGlR4/nw9DT8NDEAeYRfiRh6EzzCOvmKGRK X-Received: by 2002:a17:902:bb90:: with SMTP id m16mr46671885pls.54.1562247098764; Thu, 04 Jul 2019 06:31:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562247098; cv=none; d=google.com; s=arc-20160816; b=v13I/HKGhO7UGa6SmykS7WBKykt4svJAi3uuB5w0/AXofHLcXNPIOqPMy6wMcrXid7 lSW0Gg8Y4Uy94TeplYrgZh10/ZJfHckdhtOZHsjvrZRihhGkS0ZLnXd8gnTDaFjEA+vD 31vQq+zdOyQOPNm6Nw66Ww23k8iXy38KI+XvTUVIfqSoXjP8FCOPsOmKVlJnWfmkoo0o B0ijxmRCn24cS0yghQieq5Mykqse+wTko9+zrQcY/JMw2qB0qMk5Y5aJTdZzltcSaQvB w1TDy8eriELDxFZfosJAvzTf4pZMnNigJ0mirmTKijSHpNRvr36diHfy3yEfTJPCYpqD N64g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=lrXpNANefXW+VoCjgYKqAvFZ3q5Q7QGL43v5QVJn6Ak=; b=yoygMulgEZUJEhIUULaJ/KJMTKVj+ZWjB0EQsNgrV+t/7Uon7rvq8Cqulega+soEp7 dIkb1M8W4mDC1zduzgAA9jT4PguwqpY4lDb4/pBD8jBviplVRFPKT8zg4v4kuBsjOx0M 4ShmazjDVSUMq1FNgZVzXyqKxQovMM8WtwRqZ7Hc3x9Bh9xlkEA3S/SpRNM+d3c4Un8S uaz5nWjeLrvamEoYpVNlZ4NNe7izEC4HEJBbKgWr0oEojoaSAazP//X2zvWdELn8aOjy SnoCM8K4MIUCZbb3UcBG8u3e3N84GR7/ojDC7ap7c/3XSV1Ywb+j3gguOtI+0wp84nCZ CHLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v62si5418428pgv.126.2019.07.04.06.31.23; Thu, 04 Jul 2019 06:31:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727207AbfGDNal (ORCPT + 99 others); Thu, 4 Jul 2019 09:30:41 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:43262 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727093AbfGDNak (ORCPT ); Thu, 4 Jul 2019 09:30:40 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hj1ol-0000ig-BO; Thu, 04 Jul 2019 13:30:31 +0000 From: Colin King To: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: greybus: remove redundant assignment to variable is_empty Date: Thu, 4 Jul 2019 14:30:31 +0100 Message-Id: <20190704133031.28809-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable is_empty is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/greybus/audio_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index c2a4af4c1d06..9b19ea9d3fa1 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -86,7 +86,7 @@ EXPORT_SYMBOL_GPL(gb_audio_manager_remove); void gb_audio_manager_remove_all(void) { struct gb_audio_manager_module *module, *next; - int is_empty = 1; + int is_empty; down_write(&modules_rwsem); -- 2.20.1