Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2188350ybi; Thu, 4 Jul 2019 06:34:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7fG/mCyQd/Rp3m4ymYKMrXh09aKXfYkkzc+nIpsCHgXWac+PVM4uBr4yld7zM2WHPrS9r X-Received: by 2002:a63:f346:: with SMTP id t6mr45200322pgj.203.1562247250944; Thu, 04 Jul 2019 06:34:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562247250; cv=none; d=google.com; s=arc-20160816; b=N1oO9KFg0KRUZbUmLUml4jXOMcAnqM+SisNh/NgnSkaVkPqmCFXWcsPStPLztPlpNB mvFfuMW43S6/P2aRY2p1ng1To94/kc5MJWFvBukGrEYPzkNer7s6he1pgTWa2G1zu12E KRFxPeqNAt47CJSEItYv9Le2h2Uldsq+iJRRolNSgMm4BZSesgihFvRN9GY5Vimb/8zD wglq/GALrsJav2Nf7VfJLCQKtPs27fNuWzVX2RNqD4Qd2IZDSkEHflPvL8QBmGLvgXTM q2HvqLEGIkNx+TFoG7cjJj4HClGULw/tRAflGzbcFhT1N5AcxLy4kylC2r6NKdn97IqZ IOjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=oQVVIWl//6cOx7PlPgCwTmODIiDI0iixaOn3E5xX89k=; b=bZVraHHJseLldb5nBCO9/KuuIvQopYCmtJ0v6a6+aYKQONKoE8khUPjMqz+46jH4/z +xpRZhabUkfalSXgdlcQcMsgtNSlIKTof3gsfxbCx4XJKVrEsT5C9051yvDOCoLy9Hqo xHAqlkEciFaal01SAqwch2ikKXKdggQ9RhROSHCmGGvhV5ssFwdG4iE+Pn1je39V6wTk WU16mevfMZnFEBrQU0GFLJgWlOTs2elvI+zQTRDgMY6m33R7/na6mLoAN7zWsIsCimTJ 7kjo3OyM56eECt9hCk1zbK4FigqPvOR0nNyEMwry5htN++5b9UmDylp+hetV4NlVjEVQ hePw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tf6GWRf+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v19si5175388pjn.96.2019.07.04.06.33.55; Thu, 04 Jul 2019 06:34:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tf6GWRf+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727184AbfGDNdT (ORCPT + 99 others); Thu, 4 Jul 2019 09:33:19 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:38836 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727116AbfGDNdT (ORCPT ); Thu, 4 Jul 2019 09:33:19 -0400 Received: by mail-vs1-f67.google.com with SMTP id k9so1956464vso.5 for ; Thu, 04 Jul 2019 06:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oQVVIWl//6cOx7PlPgCwTmODIiDI0iixaOn3E5xX89k=; b=tf6GWRf+C/ZB5a/aNf2dgNIGQoefiebM+pWSkWYd6g5+42Vw8BY/Hflfy5rgyEqBIY AkjG1Lt06tXP0NTdnFXu5ozD0KVkkrgkobAiW0vi8cmliCBscS6yh3+rxtN0U4p6uJ1z aVGTXdw3d22F94J0hDEqd2hbwmDI8dNRta+U40O/xSj2f4N45oZNN1B7UxmNU3DCVt1L ifcQG3k+n8CZpalpAnKd4AWSexGUm5ZQI7LujqCoWgxTB1SArwstn8/mpG9coVpqX89g hgEkx/ETJi9fEYCLRKBtXjcBZbCUhY4ioUU7UcJQHHhhKqifAkrjSzFIjCDZ77D4IX4B Tfuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oQVVIWl//6cOx7PlPgCwTmODIiDI0iixaOn3E5xX89k=; b=f/z4GiRehr82cIICjNP5ZY7Xx28wHE1DH19Kcp607v4F27TbS6gO+LJH7vVurGtz/5 q68S327kQZY/nA6nc/RXpH+ieOdTR1ucuNnb9mVxJ4JMgvXccxg+Jd742Hd2gFU762h8 QxIa5j8iVed3HJj8uo/xZurZ7wBQSJWAEvKO+pykyWhCcN9j5sLPJlREusHLevFHjiyu 9oa9fZ22HErX79edSl7OMP69Sztfb34Q5n1JObwVdO85iTlf1wBaBmcpzxHbL5L29+25 q/iidBncAyrj8OX0GNHu+UyD0YVz4BTtzZhR5k4Q5EADXXJPiD2mYObdiD7nb4CDGRYz lL7A== X-Gm-Message-State: APjAAAUsEnWCWnTQb+2VpWYQgqeu1w7nGSslMewtwfj7i1Qm3KryJRQB 3Kv6d6jzBFQnIVQQJeP30mSFj6HQpVLvkPgfATg= X-Received: by 2002:a67:eb87:: with SMTP id e7mr22016486vso.118.1562247198710; Thu, 04 Jul 2019 06:33:18 -0700 (PDT) MIME-Version: 1.0 References: <20190702141903.1131-1-kraxel@redhat.com> <20190702141903.1131-12-kraxel@redhat.com> In-Reply-To: <20190702141903.1131-12-kraxel@redhat.com> From: Emil Velikov Date: Thu, 4 Jul 2019 14:33:26 +0100 Message-ID: Subject: Re: [PATCH v6 11/18] drm/virtio: switch from ttm to gem shmem helpers To: Gerd Hoffmann Cc: ML dri-devel , David Airlie , open list , Gurchetan Singh , "open list:VIRTIO GPU DRIVER" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gerd, On Tue, 2 Jul 2019 at 15:19, Gerd Hoffmann wrote: > .gem_prime_import_sg_table = virtgpu_gem_prime_import_sg_table, I think that you can drop this entry-point. AFAICT it's only purpose is to return an error - something already handled by core DRM when the function pointer is NULL. It's not strictly related to this series, so feel free to keep is a separate standalone patch. -Emil