Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190704093553.49904-1-yuehaibing@huawei.com>
In-Reply-To: <20190704093553.49904-1-yuehaibing@huawei.com>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Thu, 4 Jul 2019 22:49:33 +0900
Message-ID: <CAC5umyi6S0eV2AOwpxmYh-HhNaMHEKZzgnG9PteVRR0i35rV4w@mail.gmail.com>
Subject: Re: [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        rafael@kernel.org, wsa+renesas@sang-engineering.com,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        Jacopo Mondi <jacopo@jmondi.org>, khoroshilov@ispras.ru,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2019=E5=B9=B47=E6=9C=884=E6=97=A5(=E6=9C=A8) 18:36 YueHaibing <yuehaibing@h=
uawei.com>:
>
> REGMAP_SCCB is selected by ov772x and ov9650 drivers,
> but CONFIG_REGMAP may not, so building will fails:
>
> rivers/media/i2c/ov772x.c: In function ov772x_probe:
> drivers/media/i2c/ov772x.c:1360:22: error: variable ov772x_regmap_config =
has initializer but incomplete type
>   static const struct regmap_config ov772x_regmap_config =3D {
>                       ^~~~~~~~~~~~~
> drivers/media/i2c/ov772x.c:1361:4: error: const struct regmap_config has =
no member named reg_bits
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 5bbf32217bf9 ("media: ov772x: use SCCB regmap")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/base/regmap/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index c8bbf53..a498413 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -4,7 +4,7 @@
>  # subsystems should select the appropriate symbols.
>
>  config REGMAP
> -       default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W=
1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_I3C)
> +       default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W=
1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C)
>         select IRQ_DOMAIN if REGMAP_IRQ
>         bool

Looks good.

Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>

A similar problem exists for REGMAP_SOUNDWIRE. But I can't find any users
of regmap_init_sdw (i.e. REGMAP_SOUNDWIRE).