Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2227276ybi; Thu, 4 Jul 2019 07:11:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxLlAXuzKq1nz86ZmyMy/rde1mibCVaq4spUAtz/6oKkkcbVnWRFoM8FMNtgtnjeaBTEZV4 X-Received: by 2002:a17:902:a606:: with SMTP id u6mr25591466plq.275.1562249500217; Thu, 04 Jul 2019 07:11:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562249500; cv=none; d=google.com; s=arc-20160816; b=icU2f5tctV4HshQk6T+gPRrAmQPo/mGzhZH8b8bJUG5Jskk2AU0nWNPYVZ0AknR4VQ dCTr/MYjWfrPJav+0woFf9cTPwhQg3lrWcjl01uCG/fFA6fTCPKofHHjKIy3Lj5kodOH M0Vzi8wxJoYsN7f6SwWSjxL9DaBNQuO+rJrRrNjUlHr8dtOGBPOGzfbkU0VJC8noW2xE /T0yQ9qZtYVE2CH56R9rVEiEBKaA9txgo8ZFXB0cmhIGFQ+LsxuZ/TbsKPW0mnLe+wcD rPW8MNj+u9v98UoNog+2MnXfMwxRY/jTGUsFJMuDvpFvAUrObuhEqmmkLpV+TqIEQIa4 DIXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=mQ5m8rYbT8Z2US94ZaqcngLhWVtKzNxmo7qmupLUZ7w=; b=fYn6AdNAikb00pH6m4cFg2DgkK1WdB7I7q/MdGT2t1jgWRJMQSbpUNQfL1yPheZ5U0 1zrspmrMSbp3xd6xqwSVNpGgvcTilQL5qOZFZhae5pkwKgq4OmGkHnAhpvwrBy2ppV3g 5rAp9TXcZUVGLS6faTO9gyuSNXQL6t9xOfg6kbibn5kMdHfgQAtV1vcVRQmhPsSJYgK5 vkW/zg6DUrdjDRaNId838oI24euH2AfXK/ETXiYD02eAEoU00nmsMTux37RFkmGKLBgT u+Ilo+RUBaGzcOCBvUkUMiBJqclYBJnkWXIWtap25fTdEYpdhXwDMhmiVKL10/hOgS6Z RQJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oIqiaWuC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u192si5813011pgb.77.2019.07.04.07.11.25; Thu, 04 Jul 2019 07:11:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oIqiaWuC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727421AbfGDOJw (ORCPT + 99 others); Thu, 4 Jul 2019 10:09:52 -0400 Received: from mail-ua1-f45.google.com ([209.85.222.45]:37131 "EHLO mail-ua1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727229AbfGDOJv (ORCPT ); Thu, 4 Jul 2019 10:09:51 -0400 Received: by mail-ua1-f45.google.com with SMTP id z13so1181026uaa.4; Thu, 04 Jul 2019 07:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mQ5m8rYbT8Z2US94ZaqcngLhWVtKzNxmo7qmupLUZ7w=; b=oIqiaWuC6upmXjZw83Sk7A7AN228dkex7qLAmW3GCy+0EdImPA38Kk1jNfvfdrZi3V bhdR7xb6+PRPFieFo6k5xXWKmR1zWZO2TNP+7r3I4FGpkkwc588AR5j7TJ2l9+07uWmG mptGkWYKyHhVPxQUywF6hQOLXeX4k+q4AzscwADbbBwmytmPpN1YtLs1e6RLR/uOVoJO e7Lqkp7Ol5BKEYqrzorBo+PvwCgZJrMN6FLWd5OgJgmMDIjmSC/Dtrvj0F6QbItWmz8Q GEnvd5zoUJsbxd7atboADB4j8JGLKNWGEET4JkCvbgvTP8bv1aeCrtb10TIA3tScAfw/ lQ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mQ5m8rYbT8Z2US94ZaqcngLhWVtKzNxmo7qmupLUZ7w=; b=gr7gBeXUgzdM2gdkXeUVZsdvK9AAPNfQyrVbefbLO8jJLkZe3htlIHbWoan5Tx4X4I adN2RYWIWSED+iqVJ5ytmpN6Jme/3nxh8y8R9h382Y9GWkwjhxHNXNhNb+U36aaS4wKb EDUlEPxI1UKH3C8m5mbrXGMidjd1ysExXruqispVpta0m/lllt9Y9Fnm+ZtLwkk/N7xm 3IaQ457Q6E2OrLpoz7+9nfDSMb6VAOki8XjDWPJK9ZwH8dw4qmTZUE4NWNFwr5VLhcO7 0Pea+XHToos9XlZsH7gCaQhPsdyRg50Wq6466DIqeep6XxiRtfQuake6S60t0ppNM6NR 1Zng== X-Gm-Message-State: APjAAAV2gFnHqVihvaC76HDFWRlnKHn/I/rOlyx8KFJhW9+/UyN4bjt9 xRU5ECS3w+mU8lQCMEfpQki8Mf2v2yXqqeKRjmf73Q== X-Received: by 2002:ab0:2556:: with SMTP id l22mr16501064uan.46.1562249390682; Thu, 04 Jul 2019 07:09:50 -0700 (PDT) MIME-Version: 1.0 References: <20190704023436.4456-1-huangfq.daxian@gmail.com> In-Reply-To: <20190704023436.4456-1-huangfq.daxian@gmail.com> From: Emil Velikov Date: Thu, 4 Jul 2019 15:09:59 +0100 Message-ID: Subject: Re: [Patch v2 01/10] drm/exynos: using dev_get_drvdata directly To: Fuqian Huang Cc: "moderated list:ARM/S5P EXYNOS AR..." , David Airlie , Seung-Woo Kim , "Linux-Kernel@Vger. Kernel. Org" , Krzysztof Kozlowski , Kyungmin Park , Kukjin Kim , ML dri-devel , LAKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Jul 2019 at 08:26, Fuqian Huang wrote: > > Several drivers cast a struct device pointer to a struct > platform_device pointer only to then call platform_get_drvdata(). > To improve readability, these constructs can be simplified > by using dev_get_drvdata() directly. > > Signed-off-by: Fuqian Huang Thanks for the update. This patch is: Reviewed-by: Emil Velikov -Emil