Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2333417ybi; Thu, 4 Jul 2019 09:03:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqwlQ+vWA6IOizgn5NEY2kdGOAahP+1JK+gtRdTB+s9Xzmmv4ME0WDAwJQ84h/AwE4Kyf47v X-Received: by 2002:a17:90a:2525:: with SMTP id j34mr318825pje.11.1562256205956; Thu, 04 Jul 2019 09:03:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562256205; cv=none; d=google.com; s=arc-20160816; b=B5BPOmG0wUteyg6WdtH9X973CrW9at1jSAIuMBJq245h4VUQcfZXIb0jZn7APQBaBP H7vjE7fgY5tDYxFfBSqiW+ggaBXSrD72h9+NKutQ1ORl0HqQpgNq53NOc8seujnXfRRM 25dq8FfHDJn5gDJ0PUkhFMl2rTn8fqUwuri2fL8xlCMPSsQavOc7vG99d9XDQU6RAygZ 0mlhyBaqbR0eZmtzhXjhJ9j0vxynQU6SbCG/7INxBypnqnYyCV1qQ5VYDyOUJxuDPO0k xS/j1GDZ8nNFQCJwOo4V4iJWK1BE/4dDJvHhvYCBHFon+Y+n35vTip7Fvfv2+8QBBVqH DiVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=WMVNT3LN3fIl8Tf3vwPupFLmmeqnTWObXXHkwWjFt0M=; b=ueWG9HpNYrRm322AMtloS/lpVoSVNU1yXWmPEXsRmNW74ia2hzId3t2mfaXgy+1ktp kwAwBdSbuRl2vIn29JJHE3aWmuBv8hKYEClkNclTD2FInN/H6D3Inm+le1CjTvWKewnS CrnN/zoJzTLT3DR2flFaSTaRwDTriNvg/DplkeyHhOh+hn8FRW1iWsxFb7yrVipDc6mF rGejmP3/W+2N132VLG9RAz4Q1V8OSMKtYVLhKNoOJKt9rmyatcr0FpWir8aUhcxXHudx KWeP/iKL8+E5bq4GMnOraqku4EpU6filmyOW/pP+kEqhew+U7JrfIDoD4Otvyu7BaNfJ G8eA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j10si5570123plg.71.2019.07.04.09.03.10; Thu, 04 Jul 2019 09:03:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726016AbfGDQA2 (ORCPT + 99 others); Thu, 4 Jul 2019 12:00:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbfGDQA2 (ORCPT ); Thu, 4 Jul 2019 12:00:28 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 419D5C01DE89; Thu, 4 Jul 2019 16:00:22 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.136]) by smtp.corp.redhat.com (Postfix) with SMTP id BE18D99AFF; Thu, 4 Jul 2019 16:00:18 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 4 Jul 2019 18:00:21 +0200 (CEST) Date: Thu, 4 Jul 2019 18:00:18 +0200 From: Oleg Nesterov To: Hugh Dickins Cc: Andrew Morton , Jens Axboe , Peter Zijlstra , Qian Cai , hch@lst.de, gkohli@codeaurora.org, mingo@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: fix a crash in do_task_dead() Message-ID: <20190704160017.GB29995@redhat.com> References: <1559161526-618-1-git-send-email-cai@lca.pw> <20190530080358.GG2623@hirez.programming.kicks-ass.net> <82e88482-1b53-9423-baad-484312957e48@kernel.dk> <20190603123705.GB3419@hirez.programming.kicks-ass.net> <97d2f5cc-fe98-f28e-86ce-6fbdeb8b67bd@kernel.dk> <20190702150615.1dfbbc2345c1c8f4d2a235c0@linux-foundation.org> <20190703173546.GB21672@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 04 Jul 2019 16:00:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03, Hugh Dickins wrote: > > Thank you, Oleg. But, with respect, I'd caution against making it cleverer > at the last minute: what you posted already is understandable, works, has > Jen's Reviewed-by and my Acked-by: it just lacks a description and signoff. OK, agreed. I am sending that patch as-is with yours and Jen's acks applied. Oleg.