Date: Wed, 30 Nov 2005 23:50:11 +0100 (CET)
From: Tim Schmielau <tim@physik3.uni-rostock.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
cc: Dave Jones <davej@codemonkey.org.uk>, Andrew Morton <akpm@osdl.org>,
       Marcelo Feitoza Parisi <marcelo@feitoza.com.br>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvidia-agp: use time_before_eq()
In-Reply-To: <20051130213902.GB12551@mipter.zuzino.mipt.ru>
Message-ID: <Pine.LNX.4.63.0511302346480.13505@gockel.physik3.uni-rostock.de>
References: <20051130213902.GB12551@mipter.zuzino.mipt.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 550
Lines: 17

On Thu, 1 Dec 2005, Alexey Dobriyan wrote:

> It deals with wrapping correctly and is nicer to read.

> -			if ((signed)(end - jiffies) <= 0) {
> +			if (time_before_eq(end, jiffies)) {

It'd be even nicer to read if it were
			if (time_after_eq(jiffies, end)) {
like the other users of these macros.

Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/