Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190704153803.12739-1-bigeasy@linutronix.de> <20190704153803.12739-7-bigeasy@linutronix.de>
In-Reply-To: <20190704153803.12739-7-bigeasy@linutronix.de>
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
Date:   Thu, 4 Jul 2019 13:42:32 -0700
Message-ID: <CAJpBn1x=s8YLD6B3jY4aT_v=uhjA6gYJJ-DGoyeiqno7+by_kw@mail.gmail.com>
Subject: Re: [PATCH 6/7] nfp: Use spinlock_t instead of struct spinlock
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, tglx@linutronix.de,
        Peter Zijlstra <peterz@infradead.org>,
        "David S. Miller" <davem@davemloft.net>,
        OSS Drivers <oss-drivers@netronome.com>,
        Linux Netdev List <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu,  4 Jul 2019 17:38:02 +0200, Sebastian Andrzej Siewior wrote:
> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
>
> Use spinlock_t for spinlock's definition.
>
> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>


> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: oss-drivers@netronome.com
> Cc: netdev@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net.h b/drivers/net/ethernet/netronome/nfp/nfp_net.h
> index df9aff2684ed0..4690363fc5421 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net.h
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net.h
> @@ -392,7 +392,7 @@ struct nfp_net_r_vector {
>               struct {
>                       struct tasklet_struct tasklet;
>                       struct sk_buff_head queue;
> -                     struct spinlock lock;
> +                     spinlock_t lock;
>               };
>       };
>