Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2948469ybi; Thu, 4 Jul 2019 23:00:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnTEKnLM8gLrw1+Q73fVysbf52S390902U0btvF93aqcwrw39ZfRA7Q/CfXPImEj9KDbP7 X-Received: by 2002:a17:90a:37e9:: with SMTP id v96mr2626090pjb.10.1562306414086; Thu, 04 Jul 2019 23:00:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562306414; cv=none; d=google.com; s=arc-20160816; b=MheChyrfqs6ZKa82royKKg25rDcOXQKsslfePSDNosdYUOQ9hn2FxtHoltHIyRVtd1 +9CgXds6zhh31AXA5Ia5Yh0PPBYA4o7rV/Ta8tu64xt1/H6zrJgnNOnL3Q8xuw7KiD+s ZSUixoxTeKg+9NksM/RNvy6Z2jhvBRO7PQ5MUSzrI9/QaHsxdCTXJiLpH9O19ALGNhI8 mnU8ee/4juxaj/XcUUYLXMgNJU1FbbSrlVrbGOIlXd+Qy++bGdJS2K9ZmAQxsnue4NDT WTDl0ocz3MYduoE8Vh0msjS9CLIUE4i26dbtGmqA2QB70Vxd0Ju5bbj6Ez1BFTpklQ/D 0Dkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Z/HCdPY71TeWj1ENs37KLfDDynonO+nftDEJHEfPieE=; b=qBthLMg/WJKCD+VuzpqoDrh4uM8aBuRrDEEfANaZ3sHqQ8rAS12uShO1Rt+7DTjsss WCLXjw6VVaBhKEbHYkjkNYPrBoJWXYUUQuPu2vZvokzwbUgH1m9W9x5ua6tBGAlyWEhe in13LJQDRAL0w8vvUvYUjF/bx+qgKS4EGytq1k2kgnsXDxf+z2nigCAybIJ61nCWTQod i3aXRzBSFTRSAmctsWvQf+O0NJyjkPhOLGNTYC0aoBQwPvLHUI059bFQfxKww3wwcFMJ ktuPVImNjtQ/ln4oj99B7YPakIDcHgWOa3EKRFc9FFTOLA/ilZElIG1X+na45ofQ00tv uLAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aOAmi0He; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z25si7102027pgv.418.2019.07.04.22.59.37; Thu, 04 Jul 2019 23:00:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aOAmi0He; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727320AbfGEFWN (ORCPT + 99 others); Fri, 5 Jul 2019 01:22:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:36336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbfGEFWM (ORCPT ); Fri, 5 Jul 2019 01:22:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 229A4218A0; Fri, 5 Jul 2019 05:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562304131; bh=zPc/hFZDW3NZGoz+XDtC9wzD4pBipQw9CknQFsQjFDg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aOAmi0Hewyo2Fwp1kPTVZ8hoRC73tFr4syJEaZfLdpAZ8Hkv3+NPtCWYZ9n0L2zN2 KW82P4tH5C11zKMhmFZyKzgNSmTlOhplfCJemZHMSsKECRm3vjAnhgSeqoS7zxvaxI v0j86Xy8SGDNvL/2QrYL/3Fo8couT3SCW88hHyO0= Date: Fri, 5 Jul 2019 07:22:08 +0200 From: Greg KH To: Ryan Kennedy Cc: mathias.nyman@intel.com, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] usb: pci-quirks: Correct AMD PLL quirk detection Message-ID: <20190705052208.GE15821@kroah.com> References: <20190704153529.9429-1-ryan5544@gmail.com> <20190704153529.9429-2-ryan5544@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190704153529.9429-2-ryan5544@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 04, 2019 at 11:35:28AM -0400, Ryan Kennedy wrote: > The AMD PLL USB quirk is incorrectly enabled on newer Ryzen > chipsets. The logic in usb_amd_find_chipset_info currently checks > for unaffected chipsets rather than affected ones. This broke > once a new chipset was added in e788787ef. It makes more sense > to reverse the logic so it won't need to be updated as new > chipsets are added. Note that the core of the workaround in > usb_amd_quirk_pll does correctly check the chipset. > > Signed-off-by: Ryan Kennedy > --- > drivers/usb/host/pci-quirks.c | 31 +++++++++++++++++++------------ > 1 file changed, 19 insertions(+), 12 deletions(-) Should this be backported to stable kernels? thanks, greg k-h