Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 5 Jul 2019 09:12:35 +0200
From:   Lothar =?UTF-8?B?V2HDn21hbm4=?= <LW@KARO-electronics.de>
To:     Andy Duan <fugang.duan@nxp.com>
Cc:     "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word
 index
Message-ID: <20190705091235.365b93cb@karo-electronics.de>
In-Reply-To: <VI1PR0402MB360040318C9FB6656B46C566FFF50@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <20190704142015.10701-1-fugang.duan@nxp.com>
        <20190704174543.194a0158@karo-electronics.de>
        <VI1PR0402MB3600D635FF12DC861FAD9BF6FFFA0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
        <VI1PR0402MB360040318C9FB6656B46C566FFF50@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Organization: Ka-Ro electronics GmbH
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Fri, 5 Jul 2019 02:46:32 +0000 Andy Duan wrote:
> From: Andy Duan Sent: Friday, July 5, 2019 12:08 AM
> > From: Lothar Waßmann <LW@KARO-electronics.de> Sent: Thursday, July 4,
> > 2019 11:46 PM  
> > > Hi,
> > >
> > > On Thu,  4 Jul 2019 22:20:15 +0800 fugang.duan@nxp.com wrote:  
> > > > From: Fugang Duan <fugang.duan@nxp.com>
> > > >
> > > > iMX8 fuse word index represent as one 4-bytes word, it should not be
> > > > divided by 4.
> > > >
> > > > Exp:
> > > > - MAC0 address layout in fuse:
> > > > offset 708: MAC[3] MAC[2] MAC[1] MAC[0]
> > > > offset 709: XX     xx     MAC[5] MAC[4]
> > > >
> > > > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > > > ---
> > > >  drivers/nvmem/imx-ocotp-scu.c | 6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/nvmem/imx-ocotp-scu.c
> > > > b/drivers/nvmem/imx-ocotp-scu.c index d9dc482..be2f5f0 100644
> > > > --- a/drivers/nvmem/imx-ocotp-scu.c
> > > > +++ b/drivers/nvmem/imx-ocotp-scu.c
> > > > @@ -71,8 +71,8 @@ static int imx_scu_ocotp_read(void *context,
> > > > unsigned  
> > > int offset,  
> > > >       void *p;
> > > >       int i, ret;
> > > >
> > > > -     index = offset >> 2;
> > > > -     num_bytes = round_up((offset % 4) + bytes, 4);
> > > > +     index = offset;
> > > > +     num_bytes = round_up(bytes, 4);
> > > >       count = num_bytes >> 2;
> > > >
> > > >       if (count > (priv->data->nregs - index)) @@ -100,7 +100,7 @@
> > > > static int imx_scu_ocotp_read(void *context, unsigned int offset,
> > > >               buf++;
> > > >       }
> > > >
> > > > -     memcpy(val, (u8 *)p + offset % 4, bytes);
> > > > +     memcpy(val, (u8 *)p, bytes);
> > > >
> > > >       kfree(p);
> > > >  
> > > With these changes you could use the 'val' pointer directly as the
> > > destination for ocotp_read() without need for an intermediate buffer.
> > >
> > >
> > > Lothar Waßmann  
> > 
> > You are right, in fact, we can remove "p" and "buf" pointer.
> > Thanks for your review, I will send out the V2.  
> 
> Hi Lothar,
> 
> It still need intermediate buffer to read out n words (n * 4 bytes) from eFuse.
> Because 'val' buffer size is real count parsed from DT, which is not an integer multiple of 4.
> 
> For example, cell->bytes is parsed from "reg" property and it is real count like 6.
>                         fec_mac0: mac@2c4 {
>                                 reg = <0x2c4 6>;
>                         }; 
> 
> So we have to use intermediate buffer here.
>
val is a u32 pointer, so legally it cannot point to any buffer whose
size is not divisible by four!


Lothar Waßmann