Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3059157ybi; Fri, 5 Jul 2019 01:07:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqyP/2eZWi0004lIDcJ75lsN4PI4PevNXceEWySdsKKjGrJlgkCxTb2izkcz7g6K0wbF2j/t X-Received: by 2002:a17:902:8696:: with SMTP id g22mr3537644plo.249.1562314077432; Fri, 05 Jul 2019 01:07:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562314077; cv=none; d=google.com; s=arc-20160816; b=hl0FMc6sSUONH1lk/2u10oKvdHy+sKDZ2EP8jv8/ww7mWCXNZYuj4Gwq5833cA9rs6 YfiEcijPAs4O2nLEW4TITYqU7DQhbZ9hoRuOlB+3nX00h6p94KMA6ZfDXu2AKqXhdM5K Jz44pAZpdQCH6WUZCBT4PrvnCJfVN7mf4TyJh3VqgOkYnf6xG1rnWBB7wUMCVyw/+o4g kVtgcgbry+/6w/06kE+bIDuZLAG04dT4zMS1yAhYhFO0NZmYUb7cxK2/Da+9gTspj95g 34fEuw2fgB8Oo91x59p8vPIz+VonfQxcSbx5SLjKR89Z76zzku+2IiEJ2FXIZUefuApA yPEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=rl9f2kaU+reKDYdUJn4ef0kwBI27OXKabYTo8AKkWJg=; b=Mwz6mlCrmixaKnSJpV4qCoHToVVypIovyRFdl8wRui8NE33Inyc1IfL4qc67CWfj/E CKAh6t5sz00azIYajZduKE7If0mVPpr8BkvceGf/ZLJ4pQAF8ttW0lZUlTkz5l4pvsBv Nfn8xDO/LMG0Bc6GHvMUzFhS0XC+K90lOwSADkx0JvCR3uxJUqhs6bbZzLbzvZ8Hjv1S jZJx1rSa77qwCLQIHY8gGo8mc8ai1A4eGIPCgVsmtknyJY8ZaeVIf+vl6r1c8wjq2BA+ RW0L3D7GMYpO9CUSIuX/O1vMHW+U/nZJkznqGbbxuKmyu/xvc3+WkaTwVDzZCo6W4faz sHyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z3si7460580pln.198.2019.07.05.01.07.42; Fri, 05 Jul 2019 01:07:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728108AbfGEIEd (ORCPT + 99 others); Fri, 5 Jul 2019 04:04:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53188 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727506AbfGEIEd (ORCPT ); Fri, 5 Jul 2019 04:04:33 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 66E8A88304; Fri, 5 Jul 2019 08:04:21 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-9.rdu2.redhat.com [10.10.120.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E5BE8D66B; Fri, 5 Jul 2019 08:04:18 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190705051733.GA15821@kroah.com> References: <20190705051733.GA15821@kroah.com> <20190703190846.GA15663@kroah.com> <156173690158.15137.3985163001079120218.stgit@warthog.procyon.org.uk> <156173697086.15137.9549379251509621554.stgit@warthog.procyon.org.uk> <10295.1562256260@warthog.procyon.org.uk> To: Greg Kroah-Hartman Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, Casey Schaufler , Stephen Smalley , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner , keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/9] Add a general, global device notification watch list [ver #5] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12945.1562313857.1@warthog.procyon.org.uk> Date: Fri, 05 Jul 2019 09:04:17 +0100 Message-ID: <12946.1562313857@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 05 Jul 2019 08:04:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman wrote: > Hm, good point, but there should be some way to test this to verify it > works. Maybe for the other types of events? Keyrings is the simplest. keyutils's testsuite will handle that. I'm trying to work out if I can simply make every macro in there that does a modification perform a watch automatically to make sure the appropriate events happen. David