Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3174829ybi; Fri, 5 Jul 2019 03:10:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqwBqExRAaCeLgC7IGQhyn21Yb/pJRiJVuBAjuyXSxD0GRfOXtkCFJCZ2VIyAFWPAIWGCg6u X-Received: by 2002:a17:902:2bc5:: with SMTP id l63mr4605234plb.30.1562321429309; Fri, 05 Jul 2019 03:10:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562321429; cv=none; d=google.com; s=arc-20160816; b=SYL020exIa1abAAVV3rlkJ3XvTtNQEHs8zS8s7AKXlex6ctQ94sDjQNdUCCkw8E6YR 3bId+LjldmaO6eb+JMbe3tQYojH0bF7UmMYmV+iXV9+Gvo5TPV7/PFGBBPP0IPTD8Z4f A5RH2jSw7QqFHk+ktPspJtVdJD94qo8P63kWdABSdZ4SJK6GRwdz25QqAVTPk3TEJJnK wh06vyPbvrsoxDak6tbY4SABz5MhdtRDBXTmUwkcOJJECM7aIS71BcyBiLEy+qp0Jkom 5HaIh1qiKwMVOIN/RkbtB/pIzi7fpsKqBkbX723uxJqc/FKURk4lVub6iccKh+/DwBOM iREw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=Rje/IlXzJFRmaETcjeji6nF2pxF6nciwL2mIlD/m4JM=; b=zTDqPm3J1LM5RCNfPMOvbr154m40Hyug7Kqa9+FzXVg49w2P0MlVopqEwe/idBO8wa FjRP3Bph+A0GpuXymfv8MyjY6/4mSLGAIz/cSoVs5YO9pagwUfM0XOwcSolwnnLc46sf LLTpZmnUzbTrYRLNIC7C7M6dp7E6ZBYxxgrHjp5YMi3dfKforgf2dzaAVDsPPNfTJ1EU vUgHsFjCI6q2jXIgQYMRfqtqwVE4RSC1uv9uPGOnmaVxQlG0hWOrcU+FL/nY/z/E9kBw Nc0k7OlP94m/y6c7tTw86FlP7X+fE4+s6tFAYxvFvN7VxtW0wK30GvSXxnpG2v5SL0m4 k10g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f21si8102003pgv.381.2019.07.05.03.10.13; Fri, 05 Jul 2019 03:10:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728236AbfGEKH1 (ORCPT + 99 others); Fri, 5 Jul 2019 06:07:27 -0400 Received: from inva020.nxp.com ([92.121.34.13]:32770 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728165AbfGEKHW (ORCPT ); Fri, 5 Jul 2019 06:07:22 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id B11401A077B; Fri, 5 Jul 2019 12:07:20 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 33A1E1A0EB1; Fri, 5 Jul 2019 12:07:12 +0200 (CEST) Received: from titan.ap.freescale.net (TITAN.ap.freescale.net [10.192.208.233]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 546C240305; Fri, 5 Jul 2019 18:06:58 +0800 (SGT) From: Hou Zhiqiang To: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, l.subrahmanya@mobiveil.co.in, shawnguo@kernel.org, leoyang.li@nxp.com, lorenzo.pieralisi@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Cc: Mingkai.Hu@nxp.com, Minghuan.Lian@nxp.com, Xiaowei.Bao@nxp.com, Hou Zhiqiang Subject: [PATCHv6 09/28] PCI: mobiveil: Move IRQ chained handler setup out of DT parse Date: Fri, 5 Jul 2019 17:56:37 +0800 Message-Id: <20190705095656.19191-10-Zhiqiang.Hou@nxp.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20190705095656.19191-1-Zhiqiang.Hou@nxp.com> References: <20190705095656.19191-1-Zhiqiang.Hou@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The irq_set_chained_handler_and_data() call is not dependent on device tree firmware so it should be moved out of the DT parsing function for clarity. Signed-off-by: Hou Zhiqiang [lorenzo.pieralisi@arm.com: rewritten commit log] Signed-off-by: Lorenzo Pieralisi Reviewed-by: Minghuan Lian Reviewed-by: Subrahmanya Lingappa --- V6: - Rebased the patch, no functional change. drivers/pci/controller/pcie-mobiveil.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c index 8f92f05..cdf15cc 100644 --- a/drivers/pci/controller/pcie-mobiveil.c +++ b/drivers/pci/controller/pcie-mobiveil.c @@ -446,8 +446,6 @@ static int mobiveil_pcie_parse_dt(struct mobiveil_pcie *pcie) return -ENODEV; } - irq_set_chained_handler_and_data(pcie->irq, mobiveil_pcie_isr, pcie); - return 0; } @@ -872,6 +870,8 @@ static int mobiveil_pcie_probe(struct platform_device *pdev) goto error; } + irq_set_chained_handler_and_data(pcie->irq, mobiveil_pcie_isr, pcie); + ret = devm_request_pci_bus_resources(dev, &pcie->resources); if (ret) goto error; -- 1.7.1