Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3306386ybi; Fri, 5 Jul 2019 05:18:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqxLzgVqt4B6I3AjsanetnWLEvamUaDK0H6BJU4KFg1GqOld/RWVOMySy/aOSKajlAgbnDvx X-Received: by 2002:a17:90a:ad93:: with SMTP id s19mr5324388pjq.36.1562329113676; Fri, 05 Jul 2019 05:18:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562329113; cv=none; d=google.com; s=arc-20160816; b=S39dalXRwmHI3EEdADHkpcxY1o7w8mewszNH9PgdnGwX7xWK3FjapQsCOPOR9T2NC0 iTQ9ieHvGvWoCnKcmUsyimi6c6pwfm7KptcbM3x9Jhq398iTpiZmJxS/UUS4qHqR5uzp ZhQFrjZ74+mpIJ3AeIKHnQ4pGEE4DBKMgikL6arwsyARHQjG3VwtlLHwK+iNMD+XprIT /7jvkOLb6tJc6eNAtsKkAlTBYJv6mPsq0M1+v1TnJZJQHzFnKRTbecGRj8ugn6izkVvD bAi8shXNYu53xmU18bBWkZyu/FVNdxtJfv8d6VTWYFryQepnR6gwDKNFHCkn9c4mfu6L ly/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=j3lgZr5PhIwsop5RCxeelLiraufpXEP7Y5EXfLHxN4Y=; b=KbIy+UBPwDqWZTKao4YHhXo9ZZEGf6fduF9wAkQX9b696Y0wDph1DNFcnZb9aJ1Lwk d45kI2zCr0zCK/CyEgoOlanTZpP/iegGNNNbMNV/WI36FKg98hxSAYcEtrf4tHsumGlj I6wsmMCpRFU+PL9mhrApZdA2Z+KLlo1J0/dNbbOwUvY0BsyeL/+0nz5O7NXvOFJqDtWU hmPq6LMLuBr3Rx+zY7H/Btt18sB1y8tMZQVKkeeWg7Tlzfbos1Mig2618ToIrNOP9EBo AZkE+LNYYOeQKABN+ylqRS0j6Kz0XHQL6UFKjBRkDgj1rpvzsdyh/hddp8uUWTBVFjnn x7GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hAYQlw4P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u143si9132806pgb.503.2019.07.05.05.18.18; Fri, 05 Jul 2019 05:18:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hAYQlw4P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728714AbfGEMPs (ORCPT + 99 others); Fri, 5 Jul 2019 08:15:48 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:39184 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726696AbfGEMPr (ORCPT ); Fri, 5 Jul 2019 08:15:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=j3lgZr5PhIwsop5RCxeelLiraufpXEP7Y5EXfLHxN4Y=; b=hAYQlw4PRYrgwlGaAkQ/4wA7G TP0lpCsujJkEtK292CBw1OMzakLEIfE/1kBviVMFeBl1bil5alPmT7CwQVE0scMA2Yt8zitziOyKx Twvf//bKTdx4ML8P8uJ6VDrcVYIerXzo8AUOHz3OOtquKv+chJ5C+U9LMFILUwu2uDO2M=; Received: from ypsilon.sirena.org.uk ([2001:470:1f1d:6b5::7]) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjN4z-0003hS-E5; Fri, 05 Jul 2019 12:12:41 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 459BD2742B0F; Fri, 5 Jul 2019 13:12:40 +0100 (BST) Date: Fri, 5 Jul 2019 13:12:40 +0100 From: Mark Brown To: Tzung-Bi Shih Cc: Cheng-Yi Chiang , linux-kernel@vger.kernel.org, Hans Verkuil , Liam Girdwood , Takashi Iwai , Jaroslav Kysela , Russell King , Andrzej Hajda , Laurent Pinchart , David Airlie , Daniel Vetter , Heiko Stuebner , dianders@chromium.org, dgreid@chromium.org, tzungbi@chromium.org, ALSA development , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event Message-ID: <20190705121240.GA20625@sirena.org.uk> References: <20190705042623.129541-1-cychiang@chromium.org> <20190705042623.129541-2-cychiang@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: X-Cookie: How you look depends on where you go. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 05, 2019 at 03:08:37PM +0800, Tzung-Bi Shih wrote: > On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang wrote: > > +typedef void (*hdmi_codec_plugged_cb)(struct platform_device *dev, > > + bool plugged); > > + > The callback prototype is "weird" by struct platform_device. Is it > possible to having snd_soc_component instead of platform_device? Or if it's got to be a device why not just a generic device so we're not tied to a particular bus here? --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl0fPrcACgkQJNaLcl1U h9CqOgf+J1iCd1w3ReqbJfzVnRPz1davoLs8e6k9u638UeMZX3sVMS9fyeTcQtrX XpRecrQsk7CUGoFb2ji0GxnHSXWnEwnIPCRmBzoDwSmsX+33TYQI1aH+m2ZeAgjv QqHqk0vNtFAlsttbNMTvbkkkSYAAbOPW8K8AEL54U1X8EJBpqV8ljUj85yDazCou SCsQUj0LlLqN6+Gm1LmXH81KdHY06t8i7yxPATgspDLgEJYi4WwdrIyqKAtl+k92 iAuK8BXYQJO14ZrV/8f0TJbHnrszfO3RJw0UqXdZ4YMvsw0KmrNj9jYv/cL7yD8F AUeTwhBtKU+Jd353cqjNMhjYBXwEUg== =+Q0m -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF--