Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3731904ybi; Fri, 5 Jul 2019 12:49:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxryj3sFJmYu2u93KYG69EQi1PqE7xZ/4XAhpkpVTg2CWgFvaOLH23nW67eZzPZJzCsS8Au X-Received: by 2002:a17:902:549:: with SMTP id 67mr7568404plf.86.1562356188607; Fri, 05 Jul 2019 12:49:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562356188; cv=none; d=google.com; s=arc-20160816; b=qm4uNK2ZmZOekjGjH3xG+j0a6/Y41p5Vsr5NDDy4tfVpQF72Jh35FZSEdR/LSJhvFd eBidrFA0ilPOQWYtWbheusAQdy+QDHVWGT9MtpxwAGS3DObt8cjmuduGPBhDncKK1WkJ XkAgejHDkrD2zN5GKuzSZKW/TPrpQENHKZatewDeSGShn8AZhc13XdBboSNQi6wl3jjg UU9i9MzvBEBFWA+1bBTKqcTndupWdspT5tMkco8z/vB+jTUdff1KfWp79kWSnqQv7K1x msPijG6elNhMpfWQaMX16R3vobGGcR/UErHaTxY7RoQbM5cBABP+sUzGL9rkdUK5OsPM BACg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:autocrypt :openpgp:subject:from:cc:to:dkim-signature; bh=GhCFjTOr5TbTPBMndumh7nYgVxnB1KXlKWn13WWpZAI=; b=i9rUw0kZG2Q9vgL3t7o1A0nk3C4ICJMhK2ox6T7z+HBfnvbK0IEj5GxuGrNSR/n5B5 MMB6ySsT6I2ieSLSWzT00BF67faVDPHmvP6GkCyW/5nOryaOsXBFVo5UJd/4TyDelyW1 X9o3f39saZmvkd3dQkXdC9dw5bSsKz9+jUc411MxVESKm3AQ/I/mEz1NpOIQ6MrlhEjR 6biQXGFxeXj3RfbK7ybeKcYfSEGP3rNYdMSboiLtHMxD8x4eJmIffHjo56cKSUjKRv+i 15wXSOA2b14wSIkM/xybHCxowm+LB9uz1txssHicuoIctor/fIghmvVlYUxL0R9YlrZE bx0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=M1+6PiKy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z193si10026406pgd.235.2019.07.05.12.49.33; Fri, 05 Jul 2019 12:49:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=M1+6PiKy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727898AbfGETQA (ORCPT + 99 others); Fri, 5 Jul 2019 15:16:00 -0400 Received: from mout.web.de ([212.227.15.14]:38771 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbfGETP7 (ORCPT ); Fri, 5 Jul 2019 15:15:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562354134; bh=pbYTbmFg5+9MUs+Xq9U8VQNqI7dxSqfuIjlnzkc6lpQ=; h=X-UI-Sender-Class:To:Cc:From:Subject:Date; b=M1+6PiKyqNM+06i8ByDyR1wS5u+goSGY9+reKMncZcmMfUlzWnlIsSQVjuCbXYrUx lJa/uAFINkduHgHvpzx9Q0I1SIjDpbmjsZTfx9R0HJz8dBIMt1PvZJgAz5Fjyx1jr7 csXhDywM14iXqpJk+ozwzBwB63wJ2HLuWXpWI+Kc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([2.244.45.164]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MhlP1-1hvwFp0Zmd-00Mt90; Fri, 05 Jul 2019 21:15:34 +0200 To: linux-nvme@lists.infradead.org, Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Subject: [PATCH] nvme: One function call less in nvme_update_disk_info() Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <38f864df-9c90-31a3-d78d-7aaf2d726e4f@web.de> Date: Fri, 5 Jul 2019 21:15:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ANMk+Cgq9cYCEBwg4q5PhHWWyXZJCCasPJFZ1XSjkkJr2srE/mm wevMJjKH3eLpC2CkN0QIIhYmG7ZdupzQDTY3jtOSE58TJN43o0CABqoN/FDnYrj8/eEfJWJ xEv6qVRR8nVaznopsr78h/G3L71xX6pyNWxCRF5TopTVOeNpX/vwDTdWAh4ibo4ZymZxD+F S99ZbsGgvYv0v5iBFHTxg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6LQdEfRKV9A=:690brpmga8cWk+XLBPnrnE OQzlKSaBMkuM4sBSQjnoqRAKBnilpm8rJV6p+4p6/otMmews6Zq+UJwv1EkT9WRa6J8HGOxYY p6boq5AOWUMhNNKVREahvFXHi8taInH/D6d5njfv5eD6dFKr4HTHT7XIrRznyc+PfXagMj3tz XbQuxDowN177JpSUISVvgu+jcGJObw5kmnL1BlaoA3GeQpijzk+kALajnsCcaKwsCal6JoTnO xGbOdL3THgxT9BuqzV+Tllx9ByhBsH7dtVsmSt5q6avbEkiFDZKVPUwdbhheNvCCfF0GNiLAM +zm9ec/YDY91pFBQk8SC1fPGMUdiC/jg1oABigj+veHwgCQTo7yq/UpQBsH8HYrOirSDcpC+c roGFngIN2dSflvVgXK26f0Dtj3+YESD1nYSHU4wpccjTvnhrtp4U5nWBjEoMjkQCBFX19VrAr QUW426/Fs9QBUNvH2B6Ced7UVkqj6uw3OmjqKkVS60OAU6LN0emzdKgq6HsfOpO0qQ8BZTNJT 2OmZD/8IOYh47XAy2UoOIHU+pDqUriXq99nxPs7LbzGz0Crn16X3oGsf+fmPXgUfkpD1gQMAJ BrznoLiAdTUQUH8Hc0ueVailrmLL8RoJKaQd1/ntFdbKFTe4IEr5Tm0N30rBB/OCfdOA5J69k E1Hc9CNrf9kIbQd/zAKQGRNObiXk3mOMZ0ZSfEVI/rtIwgO7Qq6G2dbzGXfe5+vj4Mo8rD21k W7fh2aI8YjVJxedY3a0vCN9R8sFuYkNWZdAIurov8UJ4+j3roKhE5l5oH/lGoBSbOc/SiSCyf sP5jawQSbYiYPzN3C6UwrmEgIPxeubc0j2ix17b9mpu5PNXgp+X6+526nKuLJfQ+Zv+IqjJCS PcwTcCh5W+ovIlm/5oClalFzsTV6J9465mdYwtzfKjVAPS9/3DvxHyQ2QDJ+fCySwpYn9rNdc 9DdVlQqtcvEU2/w6dNGVA36IsyOJFwloxaRrWyAFMHwWFuZxGF0kdnqtoDXRfz4d6HRei2chN 6tzoGpVeN4pSkRY0DrO5LEoazKEkJnrB3OydpBBw60Zda+ACJ6E2QAnCiPECAScfGP0ayw9St u3zAoi52J/O0yMMIoCbW94iI89gxK5WapRk Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 5 Jul 2019 21:08:12 +0200 Avoid an extra function call by using a ternary operator instead of a conditional statement. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring =2D-- drivers/nvme/host/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index b2dd4e391f5c..73888195bdb2 100644 =2D-- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1650,10 +1650,7 @@ static void nvme_update_disk_info(struct gendisk *d= isk, nvme_config_discard(disk, ns); nvme_config_write_zeroes(disk, ns); - if (id->nsattr & (1 << 0)) - set_disk_ro(disk, true); - else - set_disk_ro(disk, false); + set_disk_ro(disk, id->nsattr & (1 << 0) ? true : false); blk_mq_unfreeze_queue(disk->queue); } =2D- 2.22.0