Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3855469ybi; Fri, 5 Jul 2019 15:39:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqymTbIaQnR172CLBVjUtyf9BVQ5fhyW34HYohjsXhddnXUF4A5sAEp5IKKHIak6msbPtWQ3 X-Received: by 2002:a17:902:e6:: with SMTP id a93mr8174587pla.175.1562366364653; Fri, 05 Jul 2019 15:39:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562366364; cv=none; d=google.com; s=arc-20160816; b=PGlGPC1zRgCKHlbOfluSCr6dhtJ2LohSGG68X9iOlTDmUkZVLPDOTE/6NBlzAdEopm BkAHBlLxlJO6Tnz+S2q+hHWlmDsRArtB19xEeezveqjGIqbF9jhb7giBI44AJi+0kuHi K18gzl5hMVLe8G9PtbtHL0J9vQgMroTvEPv/ETPpUwcFu2hmsreXiAJFnbuUARGqlD5b FsDv3j6kXb438SLAWhxCR5NciNiCA8pTEZkaAEVILZkBfiJNeERJuTKqijwIN0OWYKg1 fWKcVT+59OgAV6r3KmR6fXm3Wbn/I7F+aNdC8V8MpdPQxzwP74PtHPTUYl5gSH127bQy +Dmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=kjYuYpivZtKOk16gBQqK38Ko7oULD0iJ7C9dupZC+iQ=; b=E6bVR8RKYQsBlg8xQbpSBS1ImDCxcwNjq9rYdklf29apOnthIZIunZnFFFXUyFE47U JkORP4Nd/otrXzgQHmZMaqdUiLgfmMdy6ixlT9G+AZNtOLlCpkOPnCge/137hzRVAHFV XiOakmfVrbcsk5+eaVhasQA8ceSvu4IBXulnIvxxttenYVM17rUV9q3QcYB4dg7gBdd5 f+xq66uhAa3P6ftyxOhWlfjfJ7qCxUhGDMxOeDOCxd6jX+Es8vHheHMzW+jIw6v2nJyn CtUOYdNqcf2KwWSkYRbB73Hj2eDNBcup0e+4xy2FyZofTluWB/6TMCNtt0kblRK6JqVp 7wRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r67si9336955pjb.19.2019.07.05.15.39.09; Fri, 05 Jul 2019 15:39:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726267AbfGEWit (ORCPT + 99 others); Fri, 5 Jul 2019 18:38:49 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43700 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbfGEWis (ORCPT ); Fri, 5 Jul 2019 18:38:48 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EA2ED150428B0; Fri, 5 Jul 2019 15:38:47 -0700 (PDT) Date: Fri, 05 Jul 2019 15:38:45 -0700 (PDT) Message-Id: <20190705.153845.1823378152620818460.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH net] r8152: set RTL8152_UNPLUG only for real disconnection From: David Miller In-Reply-To: <1394712342-15778-288-albertk@realtek.com> References: <1394712342-15778-288-albertk@realtek.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 05 Jul 2019 15:38:48 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang Date: Thu, 4 Jul 2019 17:36:32 +0800 > Set the flag of RTL8152_UNPLUG if and only if the device is unplugged. > Some error codes sometimes don't mean the real disconnection of usb device. > For those situations, set the flag of RTL8152_UNPLUG causes the driver skips > some flows of disabling the device, and it let the device stay at incorrect > state. > > Signed-off-by: Hayes Wang Applied.