Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4628345ybi; Sat, 6 Jul 2019 09:17:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqwMO1eVUHum6iBk7K7u3j0IqHOcv2nY3NWgzyT8rPMVs2qSZxo/AFvW8HB2z8RnaM2ANpLH X-Received: by 2002:a17:902:306:: with SMTP id 6mr12410685pld.148.1562429842844; Sat, 06 Jul 2019 09:17:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562429842; cv=none; d=google.com; s=arc-20160816; b=QG4+X/X/lt8FMoSgQnuxG9ecfPWEFLYXMgwsW73UWq505MsSUFUZU0DGNb32wEacPr p85gG1LRoqIPMFdlWhkUEwNRT6A/OERvCEtiNpchQlrQU++hydrEgHLzXGewIbKg2ZcW 0r5sxCx5bT1sd6RuAlfZGdQYhSmHBwvZMiVJKJSbCljAIzcGpAP1m9akH4gKgp7p2/yw GOr38QPGT7KzQF7Moq3ld3XcBTQASTgazP79x4Urk+IH/KXoJDh/1C5XRSOXAOHeCA0u BXoXylTJleaj0s7+fvDEs3/XA2cLeTaNQL5KhZ3/lF1t+t+JcKb5UoL5sBFFyeVmdnd9 G61A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=bnmQjEH1vYixqqvcA510E7VkS1LxWaG+p2Hix3E3JqU=; b=FO4nfFgeRXfYjGLUTwepxI22T21pG7Py7qntZD8xXy5vb+fc/IN1ma+9VLnfyMIHXh v9utAXSzTlRgQ69dhtdoFoTif74gZVcsRqsR/cd5l9sffn2hgxLYUyp92O3GLvyK9N+n r3Lprajdu0M6CIizLTsK1gdA3odCQ5WNY+k4ArKf9YhD6N1/SmAIRkxoI1VkCTUt9T7X zoHv0UBNCYQ4fkP+y6mFMZ3zCfeDucQcaeNev30H3+19R/oBnsEfoFqzkdk1w7fAAgHQ 1DaCBBGT3GnRsxyO0DeG6a1C74Tv3JsAzcVwIfCJdlaxrqisOdEW+fODmfmwmqEBWRhZ RKyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="qicd/fun"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a6si11219028pla.259.2019.07.06.09.16.56; Sat, 06 Jul 2019 09:17:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="qicd/fun"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbfGFQHU (ORCPT + 99 others); Sat, 6 Jul 2019 12:07:20 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:35233 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbfGFQHT (ORCPT ); Sat, 6 Jul 2019 12:07:19 -0400 Received: by mail-pg1-f195.google.com with SMTP id s27so5579841pgl.2 for ; Sat, 06 Jul 2019 09:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bnmQjEH1vYixqqvcA510E7VkS1LxWaG+p2Hix3E3JqU=; b=qicd/funjrpa2MxTNeuQoPhPDV7SU+qyw6BwWY6yh7r1IaDvoqyQ07St8p9OEgylYS GqFgK/mDeKxRdWK9fBISg1CxtaYg0ECsLe8zIijMLfzhffg7KiWwNAXftRDwUfCUGYrn O/idl9gZ9KvApAbkKOZ6eJsjiPWhqoy93KMjk8awTsCUr7DprObuPppW5lQJQMN125aL zURFvuFcGZ/rBDROj87VJSuqvVu+ubO6rtbMzAXybEdbD7WKL5craHDFUxMEvLZL4W5M 7T5Epsk0F7jirsFnQ4sr6t/u7WS16NEWaF9EnF2IGLidGdRU1zxI8z+4ZP0HLQcIzZYB qzAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bnmQjEH1vYixqqvcA510E7VkS1LxWaG+p2Hix3E3JqU=; b=gFtVYICb5VbUPonTErqurKd0OM8ayIc/9U504olOlFQyxNRXUNNdBLq6vUlv5gih0Q os64RB1vWDygpk2nSTKdXSRxmMRrFh5Hqorx8i0c7KcTylIvucwC8QuXHedxbiz/K4/Q 5gFe9hNC7HA1j/86A8D/oG5nRAccIpcdGW7ne9/4NaYqyB1MTWhkNBrzOLJI4qpfGLKO QrBvyTYWbZeJfwjxQgtwsUc//m6ltS/q6VlcLdr8Kzz0Mh/4WoOQFs3b4y/0SpwEZpS1 OOEKZvHH9Ures1vehA9vA8kL9TI/4x3Jt+rMdswan5E1RWiCTDogiTPyUt3vFFKDBkCQ /hEQ== X-Gm-Message-State: APjAAAWLKeQ/biQe9m8pOcQV0RLZD/HdNhG5W1EgCs0g7k6iHJF6XAzG OzuZomD8mS/VHHk17QRhwx42Gg== X-Received: by 2002:a63:5610:: with SMTP id k16mr11733599pgb.335.1562429239012; Sat, 06 Jul 2019 09:07:19 -0700 (PDT) Received: from [192.168.1.121] (66.29.164.166.static.utbb.net. [66.29.164.166]) by smtp.gmail.com with ESMTPSA id b126sm14572448pfa.126.2019.07.06.09.07.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Jul 2019 09:07:18 -0700 (PDT) Subject: Re: [PATCH] blk-mq: fix up placement of debugfs directory of queue files To: Greg Kroah-Hartman , Stephen Rothwell Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable References: <20190706155032.GA3106@kroah.com> From: Jens Axboe Message-ID: Date: Sat, 6 Jul 2019 10:07:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190706155032.GA3106@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/6/19 9:50 AM, Greg Kroah-Hartman wrote: > When the blk-mq debugfs file creation logic was "cleaned up" it was > cleaned up too much, causing the queue file to not be created in the > correct location. Turns out the check for the directory being present > is needed as if that has not happened yet, the files should not be > created, and the function will be called later on in the initialization > code so that the files can be created in the correct location. How about we shove this in for 5.2 final? Trivial enough to do, and it would suck to have 5.2 released with this. Though not sure what devices this actually impacts, I haven't noticed anything awry on my setups? -- Jens Axboe