Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 07 Jul 2019 11:27:20 +0200
Message-ID: <s5hlfxajitj.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Nicola Lunghi" <nick83ola@gmail.com>
Cc:     <alsa-devel@alsa-project.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Allison Randal" <allison@lohutok.net>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Jussi Laako" <jussi@sonarnerd.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: usb-audio: fix Line6 Helix audio format rates
In-Reply-To: <20190707082734.25829-1-nick83ola@gmail.com>
References: <20190707082734.25829-1-nick83ola@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 07 Jul 2019 10:27:34 +0200,
Nicola Lunghi wrote:
> @@ -294,7 +321,7 @@ static int parse_audio_format_rates_v2v3(struct snd_usb_audio *chip,
>  {
>  	struct usb_device *dev = chip->dev;
>  	unsigned char tmp[2], *data;
> -	int nr_triplets, data_size, ret = 0;
> +	int nr_triplets, data_size, ret, ret_l6 = 0;

This caused a compile warning:
  sound/usb/format.c: In function ‘parse_audio_format_rates_v2v3’:
  sound/usb/format.c:337:30: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    int nr_triplets, data_size, ret, ret_l6 = 0;
                                ^~~
				
So I applied with a fix, keeping ret = 0 while dropping the
superfluous zero initialization for ret_l6.


thanks,

Takashi