Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190626132632.32629-1-axel.lin@ingics.com> <20190626132632.32629-2-axel.lin@ingics.com>
 <e1ba816f-1ecc-acc1-1f69-bc474da1061a@ti.com> <CAFRkauCtHtG0mfqXp=FuBYYqGhhMGfP3o_N3iBoRHwkQNQYtNw@mail.gmail.com>
 <b5452465-3dd4-855b-1a17-3da96070903c@ti.com> <CAFRkauBxJKcYbiT6UmKw81SAKm=AuDFu1Ez6Ttuc_EcMh_SudQ@mail.gmail.com>
In-Reply-To: <CAFRkauBxJKcYbiT6UmKw81SAKm=AuDFu1Ez6Ttuc_EcMh_SudQ@mail.gmail.com>
From:   Axel Lin <axel.lin@ingics.com>
Date:   Mon, 8 Jul 2019 10:04:09 +0800
Message-ID: <CAFRkauCeayKSvxOz8_qdFs1PX8gAWj9H3iOp0XaZQ+kndf_cUw@mail.gmail.com>
Subject: Re: [RFT][PATCH 2/2] regulator: lm363x: Fix n_voltages setting for lm36274
To:     Dan Murphy <dmurphy@ti.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Axel Lin <axel.lin@ingics.com> =E6=96=BC 2019=E5=B9=B46=E6=9C=8827=E6=97=A5=
 =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=887:58=E5=AF=AB=E9=81=93=EF=BC=9A
>
> > > With your current code where LM36274_LDO_VSEL_MAX and n_voltages is 0=
x34,
> > > the maximum voltage will become 400000 + 50000 * 0x34 =3D 6.6V which
> > > does not match the datasheet.
> >
> > Not sure how you get 6.6v the LDO max is 6.5v.
> >
> > After 0x32->0x7f maps to 6.5v
> >
> > 000000 =3D 4 V
> > 000001 =3D 4.05 V
> > :
> > 011110 =3D 5.5 V (Default)
> > :
> > 110010 =3D 6.5 V
> >
> > 110011 to 111111 map to 6.5 V <- Should never see 6.6v from LDO
> >
> > Page 7 of the Datasheet says range is 4v->6.5v
> Hi Dan,
>
> The device indeed can only support up to 6.5V, the point is you are using
> linear equation to calculate the voltage of each selecter.
> In your current code:
> #define LM36274_LDO_VSEL_MAX           0x34 (and it's .n_voltages)
> So it supports selector 0 ... 0x33.
> For selector 0x33 in the linear equation is
> 4000000 + 50000 * 51 =3D 6550000 (i.e. 6.55V)
> i.e. The device actually only support up to 6.5V but the driver
> reports it support up to 6.55V
>      because regulator_list_voltage() will return 6.55V for selector 0x33=
.
> (I have off-by-one in my previous reply because when .n_voltages is
> 0x34, it supports up to 0x33)

Similar comment as I mentioned in another path.
Did you check regulator_list_voltage() output for the boundary case
with and without this patch?