Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] tipc: ensure skb->lock is initialised
To:     Chris Packham <chris.packham@alliedtelesis.co.nz>,
        jon.maloy@ericsson.com, ying.xue@windriver.com, davem@davemloft.net
Cc:     netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20190707225328.15852-1-chris.packham@alliedtelesis.co.nz>
From:   Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <2298b9eb-100f-6130-60c4-0e5e2c7b84d1@gmail.com>
Date:   Mon, 8 Jul 2019 10:18:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.1
MIME-Version: 1.0
In-Reply-To: <20190707225328.15852-1-chris.packham@alliedtelesis.co.nz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/8/19 12:53 AM, Chris Packham wrote:
> tipc_named_node_up() creates a skb list. It passes the list to
> tipc_node_xmit() which has some code paths that can call
> skb_queue_purge() which relies on the list->lock being initialised.
> Ensure tipc_named_node_up() uses skb_queue_head_init() so that the lock
> is explicitly initialised.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

I would rather change the faulty skb_queue_purge() to __skb_queue_purge()