Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Naga Sureshkumar Relli <nagasure@xilinx.com>
To:     Naga Sureshkumar Relli <nagasure@xilinx.com>,
        Boris Brezillon <boris.brezillon@collabora.com>
CC:     "vigneshr@ti.com" <vigneshr@ti.com>,
        "bbrezillon@kernel.org" <bbrezillon@kernel.org>,
        "helmut.grohne@intenta.de" <helmut.grohne@intenta.de>,
        "richard@nod.at" <richard@nod.at>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "marek.vasut@gmail.com" <marek.vasut@gmail.com>,
        "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "computersforpeace@gmail.com" <computersforpeace@gmail.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: RE: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over
 write driver's read_page()/write_page()
Thread-Topic: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over
 write driver's read_page()/write_page()
Thread-Index: AQHVKxEOKM99KajnN0G2IiFegkrxG6atgBaAgABKdoCAAAOHgIAABNvwgAAFfoCAAAE2wIAAA0eAgAABfeCAEtCbgA==
Date:   Mon, 8 Jul 2019 12:18:50 +0000
Message-ID: <DM6PR02MB4779F9AA8C6E4391CBF7906EAFF60@DM6PR02MB4779.namprd02.prod.outlook.com>
References: <20190625044630.31717-1-naga.sureshkumar.relli@xilinx.com>
 <20190626084807.3f06e718@collabora.com>
 <DM6PR02MB47796E3306C166A91E0BAE91AFE20@DM6PR02MB4779.namprd02.prod.outlook.com>
 <20190626132715.6128d8b1@collabora.com>
 <DM6PR02MB4779D347620E88BDB943DEB4AFE20@DM6PR02MB4779.namprd02.prod.outlook.com>
 <20190626140417.440cf762@collabora.com>
 <DM6PR02MB4779B5C815FB4DAF33EF4996AFE20@DM6PR02MB4779.namprd02.prod.outlook.com>
 <20190626142021.484c4fd8@collabora.com>
 <DM6PR02MB477919D28FDC063894C3CF50AFE20@DM6PR02MB4779.namprd02.prod.outlook.com>
In-Reply-To: <DM6PR02MB477919D28FDC063894C3CF50AFE20@DM6PR02MB4779.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 58b37a04-19ea-4f6f-3d39-08d7039e6f97
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2019 12:18:50.2836
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nagasure@xilinx.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5884
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

> -----Original Message-----
> From: linux-mtd <linux-mtd-bounces@lists.infradead.org> On Behalf Of Naga=
 Sureshkumar
> Relli
> Sent: Wednesday, June 26, 2019 6:04 PM
> To: Boris Brezillon <boris.brezillon@collabora.com>
> Cc: vigneshr@ti.com; bbrezillon@kernel.org; helmut.grohne@intenta.de; ric=
hard@nod.at;
> linux-kernel@vger.kernel.org; marek.vasut@gmail.com; yamada.masahiro@soci=
onext.com;
> linux-mtd@lists.infradead.org; miquel.raynal@bootlin.com; computersforpea=
ce@gmail.com;
> dwmw2@infradead.org
> Subject: RE: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not over=
 write
> driver's read_page()/write_page()
>=20
> Hi Boris,
>=20
> > -----Original Message-----
> > From: Boris Brezillon <boris.brezillon@collabora.com>
> > Sent: Wednesday, June 26, 2019 5:50 PM
> > To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> > Cc: miquel.raynal@bootlin.com; helmut.grohne@intenta.de;
> > richard@nod.at; dwmw2@infradead.org; computersforpeace@gmail.com;
> > marek.vasut@gmail.com; vigneshr@ti.com; bbrezillon@kernel.org;
> > yamada.masahiro@socionext.com; linux- mtd@lists.infradead.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do not
> > over write driver's read_page()/write_page()
> >
> > On Wed, 26 Jun 2019 12:12:47 +0000
> > Naga Sureshkumar Relli <nagasure@xilinx.com> wrote:
> >
> > > Hi Boris,
> > >
> > > > -----Original Message-----
> > > > From: Boris Brezillon <boris.brezillon@collabora.com>
> > > > Sent: Wednesday, June 26, 2019 5:34 PM
> > > > To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> > > > Cc: miquel.raynal@bootlin.com; helmut.grohne@intenta.de;
> > > > richard@nod.at; dwmw2@infradead.org; computersforpeace@gmail.com;
> > > > marek.vasut@gmail.com; vigneshr@ti.com; bbrezillon@kernel.org;
> > > > yamada.masahiro@socionext.com; linux- mtd@lists.infradead.org;
> > > > linux-kernel@vger.kernel.org
> > > > Subject: Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron: Do
> > > > not over write driver's read_page()/write_page()
> > > >
> > > > On Wed, 26 Jun 2019 11:51:12 +0000 Naga Sureshkumar Relli
> > > > <nagasure@xilinx.com> wrote:
> > > >
> > > > > Hi Boris,
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Boris Brezillon <boris.brezillon@collabora.com>
> > > > > > Sent: Wednesday, June 26, 2019 4:57 PM
> > > > > > To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> > > > > > Cc: miquel.raynal@bootlin.com; helmut.grohne@intenta.de;
> > > > > > richard@nod.at; dwmw2@infradead.org;
> > > > > > computersforpeace@gmail.com; marek.vasut@gmail.com;
> > > > > > vigneshr@ti.com; bbrezillon@kernel.org;
> > > > > > yamada.masahiro@socionext.com; linux- mtd@lists.infradead.org;
> > > > > > linux-kernel@vger.kernel.org
> > > > > > Subject: Re: [LINUX PATCH v17 1/2] mtd: rawnand: nand_micron:
> > > > > > Do not over write driver's read_page()/write_page()
> > > > > >
> > > > > > On Wed, 26 Jun 2019 11:22:33 +0000 Naga Sureshkumar Relli
> > > > > > <nagasure@xilinx.com> wrote:
> > > > > >
> > > > > > > Hi Boris,
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Boris Brezillon <boris.brezillon@collabora.com>
> > > > > > > > Sent: Wednesday, June 26, 2019 12:18 PM
> > > > > > > > To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> > > > > > > > Cc: miquel.raynal@bootlin.com; helmut.grohne@intenta.de;
> > > > > > > > richard@nod.at; dwmw2@infradead.org;
> > > > > > > > computersforpeace@gmail.com; marek.vasut@gmail.com;
> > > > > > > > vigneshr@ti.com; bbrezillon@kernel.org;
> > > > > > > > yamada.masahiro@socionext.com; linux-
> > > > > > > > mtd@lists.infradead.org; linux-kernel@vger.kernel.org
> > > > > > > > Subject: Re: [LINUX PATCH v17 1/2] mtd: rawnand:
> > > > > > > > nand_micron: Do not over write driver's
> > > > > > > > read_page()/write_page()
> > > > > > > >
> > > > > > > > On Mon, 24 Jun 2019 22:46:29 -0600 Naga Sureshkumar Relli
> > > > > > > > <naga.sureshkumar.relli@xilinx.com> wrote:
> > > > > > > >
> > > > > > > > > Add check before assigning chip->ecc.read_page() and
> > > > > > > > > chip->ecc.write_page()
> > > > > > > > >
> > > > > > > > > Signed-off-by: Naga Sureshkumar Relli
> > > > > > > > > <naga.sureshkumar.relli@xilinx.com>
> > > > > > > > > ---
> > > > > > > > >  drivers/mtd/nand/raw/nand_micron.c | 7 +++++--
> > > > > > > > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > > > > > > >
> > > > > > > > > diff --git a/drivers/mtd/nand/raw/nand_micron.c
> > > > > > > > > b/drivers/mtd/nand/raw/nand_micron.c
> > > > > > > > > index cbd4f09ac178..565f2696c747 100644
> > > > > > > > > --- a/drivers/mtd/nand/raw/nand_micron.c
> > > > > > > > > +++ b/drivers/mtd/nand/raw/nand_micron.c
> > > > > > > > > @@ -500,8 +500,11 @@ static int micron_nand_init(struct n=
and_chip
> *chip)
> > > > > > > > >  		chip->ecc.size =3D 512;
> > > > > > > > >  		chip->ecc.strength =3D chip->base.eccreq.strength;
> > > > > > > > >  		chip->ecc.algo =3D NAND_ECC_BCH;
> > > > > > > > > -		chip->ecc.read_page =3D micron_nand_read_page_on_die_e=
cc;
> > > > > > > > > -		chip->ecc.write_page =3D micron_nand_write_page_on_die=
_ecc;
> > > > > > > > > +		if (!chip->ecc.read_page)
> > > > > > > > > +			chip->ecc.read_page =3D
> > > > > > > > > +micron_nand_read_page_on_die_ecc;
> > > > > > > > > +
> > > > > > > > > +		if (!chip->ecc.write_page)
> > > > > > > > > +			chip->ecc.write_page =3D
> > > > > > > > > +micron_nand_write_page_on_die_ecc;
> > > > > > > >
> > > > > > > > That's wrong, if you don't want on-die ECC to be used,
> > > > > > > > simply don't set nand-ecc-mode to "on- die".
> > > > > > > Ok. But if we want to use on-die ECC then you mean to say it
> > > > > > > is mandatory to use
> > > > > > micron_nand_read/write_page_on_die_ecc()?
> > > > > >
> > > > > > Absolutely, and if it doesn't work that means you driver does
> > > > > > not implement raw accesses correctly, which means it's still bu=
ggy...
> > > > > I agree. But let's say, if there is a limitation with the
> > > > > controller. Then it is must to have this
> > > > check right?
> > > > > I mean, for pl353 controller, we must clear the CS during the
> > > > > data phase, hence we are splitting the Transfer in the pl353_read=
/write_page_raw().
> > > > > +	pl353_nand_read_data_op(chip, buf, mtd->writesize, false);
> > > > > +	p =3D chip->oob_poi;
> > > > > +	pl353_nand_read_data_op(chip, p,
> > > > > +				(mtd->oobsize -
> > > > > +				PL353_NAND_LAST_TRANSFER_LENGTH),
> > false);
> > > > > +	p +=3D (mtd->oobsize - PL353_NAND_LAST_TRANSFER_LENGTH);
> > > > > +	xnfc->dataphase_addrflags |=3D PL353_NAND_CLEAR_CS;
> > > > > +	pl353_nand_read_data_op(chip, p,
> > PL353_NAND_LAST_TRANSFER_LENGTH,
> > > > > +				false);
> > > > > As the above sequence is needed even for raw access, PL353 is
> > > > > unable to use the on_die_page
> > > > reads.
> > > >
> > > > This "de-assert CS on last access" logic should be done in the
> > > > exec_op() implementation. I also wonder how that works for
> > > > operations that don't have data cycles. Oh, BTW, most chips are
> > > > CE-don't-care, which means you can assert/de-assert CS on each
> > > > read_data_op() without
> > any issues.
> > > Yes, we can assert/de-assert CS on each read/write_data_op().
> > > But what about transfer length splitting?
> > > +	p =3D chip->oob_poi;
> > > +	pl353_nand_read_data_op(chip, p,
> > > +				(mtd->oobsize -
> > > +				PL353_NAND_LAST_TRANSFER_LENGTH), false);
> > > +	p +=3D (mtd->oobsize - PL353_NAND_LAST_TRANSFER_LENGTH);
> > > This should be done as a part of pl353_raw_read/write() right?
> >
> > Are you sure you need to do that, and if that's the case, do you have a=
n idea why this is
> needed?
> > Is this "read last 4 bytes separately"
> > thing is needed, I suspect it's needed for any kind of input-data cycle=
s, not just page reads.
> Yes. It is needed. This is Limitation in the HW, need to handle last 4 by=
tes separately for both
> page read/writes
Just wanted to know, is this fix OK?

Regards,
Naga Sureshkumar Relli
>=20
> Regards,
> Naga Sureshkumar Relli
>=20
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/