Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7001955ybi; Mon, 8 Jul 2019 12:27:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZuUGq8x5rndBRRlXrE34kUv9oqUJciAW12FOTONDf6s27YdfEUYjLRXYPeNUryGc51ycb X-Received: by 2002:a63:10a:: with SMTP id 10mr26048028pgb.281.1562614057645; Mon, 08 Jul 2019 12:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562614057; cv=none; d=google.com; s=arc-20160816; b=i5TbDozYMDlA0GXoHkA6ucaDhnWQ6Im3MtzBao0DEcwFGxCLVESRHN2u4vir0fGgef K+QBkrp21vK5y2srR9ljhHFSBzWvdn3RlRL0WEkR3hPIezE45EQL688y0CP57y/KBKwh VVo5qSDx19jUXW392MGVFNVbqipow6yAQpG9nWbCWnMeQ/4cIlDAbzyHVxLXWt7Bjtaa Qoz2J5P1LVTuXwatvmwsKhDoWy8h7DinafGeWrGEg3BeNEhIbiCvMEcUwYGKvvBrtLUd gastUQw/5aaHx3hoHjDDfiWYY3Q7EhfRw+Mq17Snfk/hHiTne/vhGZVtjLe9KLS7ZQvD cyCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kXUN90sDFULd4qRU/R3KEOn/usuVWjJoGJ35nR0nQ18=; b=QGVzmewGHO5lGNFSnKHbY+2/vBWteX22jMi/rRry/jAImRn+e/L7Epi/2sP7i0GqKp bpqd0gzv3+s+RkTAx1IcjKTq5abYJ5CbFfQZTMjWmMtAIuAUO0SfLYZON9n36mgyF6BW lqgfgMYxv0xkFFXpDXpkTSUSducce3zKJVNGJFCuJDEcsi0D6k4NhodDnWzk/aFall3l DVVx3T/Rli7aRfjBdErBEemBz+VngLSA5yiOYAHvXrEGjeMatj4AAaSl8iPCym6ZqjXM reKux1lG1ZBIO7nWlz9tT0RnSxSXEqQh3HaBfkv9co5QsezKW9n7NmE1ZDKIVy6izQRY ylhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Xl9uEj6O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si21005700pfc.54.2019.07.08.12.27.22; Mon, 08 Jul 2019 12:27:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Xl9uEj6O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729704AbfGHOlY (ORCPT + 99 others); Mon, 8 Jul 2019 10:41:24 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]:38094 "EHLO mail-qt1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728764AbfGHOlY (ORCPT ); Mon, 8 Jul 2019 10:41:24 -0400 Received: by mail-qt1-f172.google.com with SMTP id n11so18231019qtl.5; Mon, 08 Jul 2019 07:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kXUN90sDFULd4qRU/R3KEOn/usuVWjJoGJ35nR0nQ18=; b=Xl9uEj6Og+rO1HLpisU7MOQS4uv+UWSEBNNTBNCnDepQBNXTF8mBQpk9jo/3wdKibZ CtZ5kQkMen21+OKQuJ+PCew8yXZuL5r+BgvKpLxdZM9mmLPQ+IYG6A+qUCJCGIEZ8tnH reW7Nkw1QthoOFm1CoYBce4mMtko7w8uWB1P05mMGNTOsZXKHk1cluXKkadnDTJGwCBm IGzeblqdEzm5X4MFpL3O715NYXJ49/og3rViPEBVtXDCIra2D+aJBBXOv9Wf8sSq/MwJ Z+c7nb/En3PazH06XUDEysCWZsK/YpFDRy6/xAUpmjPARQnRlTG5Jc/8fnHOcuzk4zWR REOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=kXUN90sDFULd4qRU/R3KEOn/usuVWjJoGJ35nR0nQ18=; b=k+0pISdu7F130TrTO4mCoz5vkU3z7TH7JDaABJEHfm7Kok9vMYBBX91Rrpy9IY65dq meUM13XhZMBJ/lcu4GAKCHBD7/QsBEqXb9n2TTxeZX0lvQfOg/vqP0YUcFPvyCb7wwn8 0Vll0p7bKo4Nhe4WguZstmCy1tw+tHv4JqX+3fhLwN940v/xs+XhlBNOZDI6muFVTTuB zLYQoTIb6zcVQN1pOuamZi4GYHrCDhXJCYYWpUKfv/OZ8420uremGNztC7JM5GbQTyQA CIOwVQl2ltGQ28Rt7Ca8t9sRHP6WbZ9vJU6GYmxn6LKVGMT8AjdJHP6CnO3cHHfyxtwG XQbg== X-Gm-Message-State: APjAAAVsLA31yXLimn7rAcA3CEE1PAJSmIkHoDoVYT7SxzOLtsIgBxSj K8iDcrxMbcvjyWve7VgpK1U= X-Received: by 2002:ac8:3449:: with SMTP id v9mr10281942qtb.163.1562596883530; Mon, 08 Jul 2019 07:41:23 -0700 (PDT) Received: from localhost ([2620:10d:c091:500::2:fa50]) by smtp.gmail.com with ESMTPSA id g3sm7342207qkk.125.2019.07.08.07.41.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2019 07:41:22 -0700 (PDT) Date: Mon, 8 Jul 2019 07:41:21 -0700 From: Tejun Heo To: Peng Wang Cc: lizefan@huawei.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: simplify code for cgroup_subtree_control_write() Message-ID: <20190708144121.GA657710@devbig004.ftw2.facebook.com> References: <20190708130132.5582-1-rocking@whu.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190708130132.5582-1-rocking@whu.edu.cn> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 08, 2019 at 09:01:32PM +0800, Peng Wang wrote: > Process "enable" and "disable" earlier to simplify code. I don't think this is correct and even if it were the value of this change is close to none, so nack on this one. Thanks. -- tejun