Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7147764ybi; Mon, 8 Jul 2019 15:36:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3K7X6XWbnj3VWP6+nUa2Nk9dDFSA6OJZTD0CwuPf6a20vbbNN7CJx9gyRyrmMFa9GRNFt X-Received: by 2002:a17:902:20c8:: with SMTP id v8mr28050774plg.284.1562625364022; Mon, 08 Jul 2019 15:36:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562625364; cv=none; d=google.com; s=arc-20160816; b=t3YLMXjUILTs7+0OjTYxsssUfEQkMxtGdpk++4Os57E3KZg9KmuUs8vmTC60iH88EU IYFMw27xApuuVRG0NhichjwPxsKXqO+9XtOZIZe3L4UQAhMTEN1+ieIso0xT3MobgIj0 ld5rZ8CK3aM3uAesHhG0h0XS3m5f3ua1eAWuGKguwrpXNHz1LNjfdDp4Q66TohNh7ywL oCihR+ACuIJo5TQXRHePumqH7wh1dCGM8GZKL8/scQajO/bb0ud4yBAD9BITTpNVxlQ/ SDiVNUajPjFWVQ/af9bqJl8R36L537I+w1QSwwV2UARPMepknrA+xWukaThHA97+QEN+ e2Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DI+UNtYUdhCEjVac5ebWhXMquktWl1WIao2L8t6LlLk=; b=0EgXpS30PNGc12V25IUsoguU/lSCUOeNbS/dV2xS0LTwsFeGQms6XjQhBiUqEqn3kV vFrYHQzv/8IiGQCtTp2YV9mtMbkQ4lKQQtUcbPuGmHKKPPWVEe7M0XmkzzrJf3Pk7Dnn 4dGBc1g73YhZaW0KxmSkY9ku/tCSTZu2wHSSJAYBzFHep7dNw7LhTdVwKacmK09F3ww0 CEVC9uMdVnp7W676n8l6Av6P+pUH6Qi2IrXe7KtABI4tRotk5YunF6zfjrX3fEeFX5td XZIg83JoUimmIYmAlOqJllcvIKTkX35kvF+931R/mnG53FMglEsqfVvmuDzfgAOAONNx NwOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HScheexg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d38si19831741pla.287.2019.07.08.15.35.49; Mon, 08 Jul 2019 15:36:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HScheexg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387467AbfGHPVM (ORCPT + 99 others); Mon, 8 Jul 2019 11:21:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:46616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728264AbfGHPVJ (ORCPT ); Mon, 8 Jul 2019 11:21:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7F42216E3; Mon, 8 Jul 2019 15:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562599268; bh=OyvPrMEsL5zESbuuUbF6mok4H+383Nhd1CEAyymND5E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HScheexg3J8PHfJdGCEJdNc+tIT9gGXi3Po60k8KIaD4osYrIvXrHt4Q37FJNdVqc FK4zOHpGLpIBIRJ2gPz0auILwSCZzLzx0MHQe6j8bVlHpS9TpczpqShjpw5BXJQ4Ae ZN7bjvVmv6s/wug2sisKovUpA5cBaaA9HuteMQ50= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stephen Suryaputra , David Ahern , "David S. Miller" Subject: [PATCH 4.9 060/102] ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop Date: Mon, 8 Jul 2019 17:12:53 +0200 Message-Id: <20190708150529.566741992@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190708150525.973820964@linuxfoundation.org> References: <20190708150525.973820964@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Suryaputra [ Upstream commit 38c73529de13e1e10914de7030b659a2f8b01c3b ] In commit 19e4e768064a8 ("ipv4: Fix raw socket lookup for local traffic"), the dif argument to __raw_v4_lookup() is coming from the returned value of inet_iif() but the change was done only for the first lookup. Subsequent lookups in the while loop still use skb->dev->ifIndex. Fixes: 19e4e768064a8 ("ipv4: Fix raw socket lookup for local traffic") Signed-off-by: Stephen Suryaputra Reviewed-by: David Ahern Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/raw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/ipv4/raw.c +++ b/net/ipv4/raw.c @@ -197,7 +197,7 @@ static int raw_v4_input(struct sk_buff * } sk = __raw_v4_lookup(net, sk_next(sk), iph->protocol, iph->saddr, iph->daddr, - skb->dev->ifindex); + dif); } out: read_unlock(&raw_v4_hashinfo.lock);