Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7147851ybi; Mon, 8 Jul 2019 15:36:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUDvb+rgag7Fk4EwQYEzMAUHYu1LlyX2ZTS5swA8kFbvl4uOSjVTWuAx+mzJyeL57yGuWy X-Received: by 2002:a63:1657:: with SMTP id 23mr24888888pgw.98.1562625371492; Mon, 08 Jul 2019 15:36:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562625371; cv=none; d=google.com; s=arc-20160816; b=J9fdRI7645wHO2wy4oYWzBLFnZL2fqIW9pf7NAY+w9dOnH22j6/vQLN4zKNCa4ybrl IMmCoHk40ECOSLpQsZmhZtlWjvruj+WxNK4oTVPkOQh7mxh1Oymf8S65LYWihn8ho2p4 UlAB0BQtkYCJEHzntqLzfqXV9R9wUeNXUfnJGRGQ0GL0SFt0Fr+gEbIHHqM790DcSq+1 CzBXz0Mby/2Gyb7kqXJ5Se325mew09xYPZvzJTgZy+SxvdFSIp+F8LmChsd5bkPUScPH D6FPy7qXGnD0X8eGMfdnmg/LBDLX44rujPNfixnwor7m0Iu52cuafueM2gEJTo0L/prz KrdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YonERamklQN9Tu87Iy1NomrnXNQBa9XFJCLCn7W3vH0=; b=KOVeRi8UtzSZ80/ABJWDNddpLsVyCtJjAArZa5fsA7S+IYESKv5TJA0nI9VYHFKsVy rEmgNgh1ZJLmTqOE43xwkjjJOZfrcOnOrbjoaZ44RBRuaPoDqJMBoVFxs9CESN/k9oQV 6jNWzBddZBrzvPInLZK4MOArD054bjKffpMMQegdeWjYTknb4qpGGYyiYN+AaGj2SfZa JocIcHxCnPWBwdizDBxflE5iojUKdDz1zdeOq3v+6wDB/WhmBaqB+58y7nFNhSTMImdK 6Hi36Bom2YqRSeeWgOmnOX1/NTdAs08WUloOXNINtIMA6G6UjxCoRvacrw2qmpCiNjeL /V/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mCCE4keT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 11si16036648pla.248.2019.07.08.15.35.57; Mon, 08 Jul 2019 15:36:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mCCE4keT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387670AbfGHPUz (ORCPT + 99 others); Mon, 8 Jul 2019 11:20:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:44402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387421AbfGHPTu (ORCPT ); Mon, 8 Jul 2019 11:19:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E836E21707; Mon, 8 Jul 2019 15:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562599189; bh=bPbReT1Q2wWR3wdpKMn+8Jo3hIt0ICft7mkQIAevbeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mCCE4keTrNyRCJU5OSjh8YR3lj7KtJQLm0H4N/8VXtvAQ6trCwa/TyebCixobXa57 C9sRTBEjZX4Ph0CEjeck/TSx5PqehMR0YXlP/Hndtlii2asSnIuVwrl7Q3NZwfxRMc Pa6vX51GFtc/ESGQ72V+HFT+v8iRK/nQ9F0wJoLM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johannes Berg Subject: [PATCH 4.9 034/102] mac80211: drop robust management frames from unknown TA Date: Mon, 8 Jul 2019 17:12:27 +0200 Message-Id: <20190708150528.144266776@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190708150525.973820964@linuxfoundation.org> References: <20190708150525.973820964@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johannes Berg commit 588f7d39b3592a36fb7702ae3b8bdd9be4621e2f upstream. When receiving a robust management frame, drop it if we don't have rx->sta since then we don't have a security association and thus couldn't possibly validate the frame. Cc: stable@vger.kernel.org Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/mac80211/rx.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -3568,6 +3568,8 @@ static bool ieee80211_accept_frame(struc case NL80211_IFTYPE_STATION: if (!bssid && !sdata->u.mgd.use_4addr) return false; + if (ieee80211_is_robust_mgmt_frame(skb) && !rx->sta) + return false; if (multicast) return true; return ether_addr_equal(sdata->vif.addr, hdr->addr1);