Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7147860ybi; Mon, 8 Jul 2019 15:36:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqx0ky9IxUCKS4/+3zx3mhb8X09VJFhf3RP3/QHo7HNJ319kZy3/lC6VchHF2OpHIALrInQy X-Received: by 2002:a17:90a:8d0d:: with SMTP id c13mr27644776pjo.137.1562625372422; Mon, 08 Jul 2019 15:36:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562625372; cv=none; d=google.com; s=arc-20160816; b=C7K7jyfwO2UY5WKt4/12illWMIKdCk/U0yB9yNxyYXyVMuKLz2dx5GwXIPXk+EkwXX X+PkLOron38ITQpswBig32iSHFk5PrKmhxQNmTSxId272nKH5+A6lfsZx9eQY4OGyYsD asaB0IPXGS77MxTkEosPNh+ThgLojj71kcuqWIJKmlaGtA9gaaZ4EUxxSJVTwWE/82/x u3dY/+LKjArqm2835F34HUgW7rTyoJERu64xwUjFULBovW3MVfuoN8z8DiA7mMzZz/0y AAaLMkGPkjrpvuclQcF/9J/18wNiFXPUvn/VIqEQvve0GHUNsWPgCF/udEtEPNxtvSEJ JUng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=U/3ls6EssxMB0AwOUxLk8aZbf4WN4DP/6MrGoX18cSw=; b=WJbbnJIrhurxYwoyktGI9nw8Xz71oO1ACYlOL2ebDhbWh8G7DUtV1z/FuAydCPGwon WIrAL33iEeDGOpBfgN+LLaW25dABzdno6YUJAUkaAtPK+coi/Zia5T1f4yeEVlDjnYA2 kTdoZ5Vh/cVhwV0FeDGn7/kAzVaWD5tjtjnRKlV6/PANgoiR8WjGKraraWMbITT+Gyx/ TomBbE7XxzG0m0uKyLkjJ1MwjEcSbacsIKSJ5KVJeO/f7Rhj+Nry4On+KsODVxNeNzGN 71h6pWv4kWePxkyDPJ+SJWjw736y4c0OYmUTREbwgH/ZkTKo+4QYnugrmuYHELgdGx4R 06Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="hI7Prt/f"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t25si10499708pgl.7.2019.07.08.15.35.57; Mon, 08 Jul 2019 15:36:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="hI7Prt/f"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387743AbfGHPVb (ORCPT + 99 others); Mon, 8 Jul 2019 11:21:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:47226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387516AbfGHPV2 (ORCPT ); Mon, 8 Jul 2019 11:21:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 924602166E; Mon, 8 Jul 2019 15:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562599287; bh=9L0SttTa0BIq1Uf+MGhfQMvOxZrYpehlrhdYX9je6l8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hI7Prt/fF/VYR5FpIhyGCuxdVvN25DA6xVihRDiZKAKgt0EnPJ9SWSTOzXrRiXEL3 oWhSJcXF4c24GNqs62VM8RTZu+8vsaf1pkQ8O1DlO4NICCash8dL977ajaRPufgIrR hGlobMU/Y0f5LfnOfrZL1GLyeEcXaD3WmEFw4/Ds= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matt Flax , Charles Keepax , Mark Brown , Sasha Levin Subject: [PATCH 4.9 066/102] ASoC : cs4265 : readable register too low Date: Mon, 8 Jul 2019 17:12:59 +0200 Message-Id: <20190708150529.864746321@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190708150525.973820964@linuxfoundation.org> References: <20190708150525.973820964@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit f3df05c805983427319eddc2411a2105ee1757cf ] The cs4265_readable_register function stopped short of the maximum register. An example bug is taken from : https://github.com/Audio-Injector/Ultra/issues/25 Where alsactl store fails with : Cannot read control '2,0,0,C Data Buffer,0': Input/output error This patch fixes the bug by setting the cs4265 to have readable registers up to the maximum hardware register CS4265_MAX_REGISTER. Signed-off-by: Matt Flax Reviewed-by: Charles Keepax Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/cs4265.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c index 6e8eb1f5a041..bed64723e5d9 100644 --- a/sound/soc/codecs/cs4265.c +++ b/sound/soc/codecs/cs4265.c @@ -60,7 +60,7 @@ static const struct reg_default cs4265_reg_defaults[] = { static bool cs4265_readable_register(struct device *dev, unsigned int reg) { switch (reg) { - case CS4265_CHIP_ID ... CS4265_SPDIF_CTL2: + case CS4265_CHIP_ID ... CS4265_MAX_REGISTER: return true; default: return false; -- 2.20.1