Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7154201ybi; Mon, 8 Jul 2019 15:44:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzcihMDeID8Sv0ez14blwyxKj08AVrBhNPY0ZkwV+lLAhXbtGaZOCsQTIY0+6K3eygVJblW X-Received: by 2002:a17:90a:d14b:: with SMTP id t11mr28682683pjw.79.1562625885870; Mon, 08 Jul 2019 15:44:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562625885; cv=none; d=google.com; s=arc-20160816; b=LqMzcJcW8DCG/+lPwNEEuMdm5rUaETcjCkQbuAdwfrC+IGfGyVB5nrxftw+MLwnWkp 4xoFi+RMem/LCnJlzmRArQ2VBv6LWGHo357kZyaCYGSgzRu/rKzmGVJmZgUZ+y5HWJ3P MO6HpXEkR+1LNjcj6qP1bmNnJmqCd7pJKER5gpSeLPL282Fpsp4Cfx+l23hfuLNh82WU 430CWhXiQTTefclb71GZnHIzDkrpuOYNq9kT1Tu9fpQ1T2SEX4U6FlIPFCQgtZsXl05z G9F6UhXaNIQo013UI836yEXKQ2Ui8j6cZ1n+AoYViaFutBLCMuXor6gWBJ7c3xAFMvIA C2OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8IxAaS8HkYeCdm6ofdJNfkVr0RYEAJ+U8cg6TKAE1aA=; b=PY1ognl0wXYce+x1SXaBtM669iS5doPrbNBGcfxkFFNgSBfUD4Lce3t/DDI1pu79hM HqwF4NrUytGGYBgDUXvQ8hZHOoFJv9bgh4FhuB8VQ568cogWt1aWKjvjH6IYbMzuWkax 8O+v+whYGko9P0mrAgxa0OxRbigPWOKFCQE6v4Rq5hP0PkRFK4RUxneaLYyTLV/kDKJs YwEty8BZrbL6n7wX9dcCBfXg0tCNWGerEWP9F9oddhWYoi7G2CZUrI09LKaMYn0HkhxC 05BthZGcdJTAjYPzjw5hNIOnDwtH/ouOIcOqKWDoKG6qFW/OVN8spXa5+sLGhhliOOBi XL0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=L4VgEUxF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cx7si700492pjb.51.2019.07.08.15.44.30; Mon, 08 Jul 2019 15:44:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=L4VgEUxF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389805AbfGHQmq (ORCPT + 99 others); Mon, 8 Jul 2019 12:42:46 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:43106 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729501AbfGHQmq (ORCPT ); Mon, 8 Jul 2019 12:42:46 -0400 Received: by mail-qt1-f194.google.com with SMTP id w17so15536758qto.10; Mon, 08 Jul 2019 09:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8IxAaS8HkYeCdm6ofdJNfkVr0RYEAJ+U8cg6TKAE1aA=; b=L4VgEUxFKymN8SdwCiz5jn/rBEPjrGbx7eFnC/6wSUv7PRduz3U9K5Wb58pE9nCwOh K4B+yYRyrknRJhYhK5GxOAr8okc1478Hpn7cwz/VKt0SCzvrBwHR/NOc9+F67juzgoUl TlucAUvTpmHDN6YI/nfX0Cv+I3FnSvxeTZbthwIBDS/D5/643uM+t1caAPoJBE3QKINO hkjzqay4+jr7+ZiC4mBgaYshjyViUjma8mTmO9MpWs5vwFYwofGWzCwYgk9D7k/ajgk/ 0RpyJHJRof2GfzuXUrUDsf76MOC/CVeHbyq6lFHXgsRZhHhALQFMfMuY+g/Evqa19ZPf upmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=8IxAaS8HkYeCdm6ofdJNfkVr0RYEAJ+U8cg6TKAE1aA=; b=h7vsA4/009uCoTiU7rnU+ZgLpGRAwol2QCfpv4MkxyIOmD/8B9BstXrx6rrI2kGVBV vZ8SCH9soz8XVtx+jkBL0l+FepQQLCl711+gqzoA25pfX9/m9lbwu8voKs/ha40SubYJ BKd2ju/JO1D4mErMe7xyABgmx0Z9t/lwNwdO3BKra7z2mqsKfIALfS+90uev57NjXjko eViyQG+RjpJ8KHjQShDwIlrXwJCamqY/2GIIAP2+eH15CGb4ypTq4M2tN1EblDo2euDQ 3EHI8UxJroBMANAw35RciqmBHKeQVHQBubMoWuKItCGjv9qgdA8bCtyGhK/+sLONr9UG IocQ== X-Gm-Message-State: APjAAAWY0f0zvd0tdsVJ/yBIEeIbae/CQfVgc9gpJr6wYUgZqjZAw9nI pOW6CaujoWSfh9AlcHw1dvYhFaNlAwE= X-Received: by 2002:a0c:95c6:: with SMTP id t6mr16273425qvt.134.1562604165035; Mon, 08 Jul 2019 09:42:45 -0700 (PDT) Received: from localhost ([2620:10d:c091:500::2:fa50]) by smtp.gmail.com with ESMTPSA id y42sm10823867qtc.66.2019.07.08.09.42.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2019 09:42:44 -0700 (PDT) Date: Mon, 8 Jul 2019 09:42:43 -0700 From: Tejun Heo To: Peng Wang Cc: lizefan@huawei.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: minor tweak for logic to get cgroup css Message-ID: <20190708164243.GE657710@devbig004.ftw2.facebook.com> References: <20190703020749.22988-1-rocking@whu.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190703020749.22988-1-rocking@whu.edu.cn> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 03, 2019 at 10:07:49AM +0800, Peng Wang wrote: > We could only handle the case that css exists > and css_try_get_online() fails. As css_tryget_online() can't handle NULL input, this is a bug fix. Can you please clarify that in the description? Thanks. -- tejun