Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7156304ybi; Mon, 8 Jul 2019 15:47:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFTlwUg2reDNGSrGeIJ+dRb6fSN3qXqV8llnKHgWK2xjXTIsq/25kJmSHMdUrOkVHiZlvj X-Received: by 2002:a17:902:2862:: with SMTP id e89mr28100450plb.258.1562626038367; Mon, 08 Jul 2019 15:47:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562626038; cv=none; d=google.com; s=arc-20160816; b=mOCJ4gjjA55RMI1Qa8B1ko4woY9jbQ/Vcf1TP37uQDCmAXYObbQ2WT7uwJCesoLG3g qmGmFUgfLJ0yATccoJbfB3Q217yzJjNCGdjQpYvOQlX8qs/A2at0N3S2JE8y2zjsmxts GZEJkKwOTp/zIjs9szrR1a7ywImZrJsfkeSlFhEveamIwdb2rE95FtO/kd5b1AnMLNbF H1hKvqKh4usxoP8OEbSR8JjjtWZ7b5TQJVAOY6EHHyK3guyU1Gbe8htiT4HnsVkMLfa3 MjZ7DqN3N3/lz2tMV8OGT5yOH8gTAYKpKWcAY1Gi2HBxihrksuEWD6brdgue7EmJvfeR cIDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=M8LkBiJU8y0ucUqOrN1FlXF4qBz/33fCuxq6Psu0O6k=; b=De38GrynH5hs5ZgVcgJMB3YHaV6lbM0n6aCHJUj2WhSE9y0S0Hq3Vt0HaQbjfNRDWe 1o7oEo5V2SyGi3Q/DO2Vssqo87sy7C3ccGJMugNp+dQVBAXlUpLYZTc2DtKnPhbDvEqn ADWMwgB3o8JA2uuxWi7d2Le/hU+0rD+LD62FsLJNOekgx0atOfdYXGjD4r1T3HCsGaat jzXqAIyUDxKo5XVMxSMvHJYzd3xNPraiB4ZC1Pj44DEZd6ZLkK1IFgUYxbIpPMvMoGo0 hiTcPrY6PabZe0G+hta/NxNupSFYac7lO+s4+Q1TaJQgpHyn3+fonFaamPe3ozejlEGb alww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6si20236836pgb.201.2019.07.08.15.47.03; Mon, 08 Jul 2019 15:47:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387592AbfGHSNE (ORCPT + 99 others); Mon, 8 Jul 2019 14:13:04 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:46688 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728624AbfGHSND (ORCPT ); Mon, 8 Jul 2019 14:13:03 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hkY8D-0004Kj-3a; Mon, 08 Jul 2019 20:12:53 +0200 Message-ID: <533462cfc4cf42be9886078a1d8b450d07cbbf6e.camel@sipsolutions.net> Subject: Re: [PATCH net-next v6 04/15] ethtool: introduce ethtool netlink interface From: Johannes Berg To: Michal Kubecek , netdev@vger.kernel.org Cc: Jiri Pirko , David Miller , Jakub Kicinski , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , linux-kernel@vger.kernel.org Date: Mon, 08 Jul 2019 20:12:50 +0200 In-Reply-To: <20190708172729.GC24474@unicorn.suse.cz> References: <20190702122521.GN2250@nanopsycho> <20190702145241.GD20101@unicorn.suse.cz> <20190703084151.GR2250@nanopsycho> <20190708172729.GC24474@unicorn.suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-07-08 at 19:27 +0200, Michal Kubecek wrote: > > Second reason is that with 8-bit genetlink command/message id, the space > is not as infinite as it might seem. FWIW, there isn't really any good reason for this, we have like 16 reserved bits in the genl header. OTOH, having a LOT of ops will certainly cost space in the kernel image... johannes