Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7186110ybi; Mon, 8 Jul 2019 16:27:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0oPRgz2YPWk1nMWFWuCARZL83RQUanT4n5MkiIi4sOROIwmbxo1HkQAh7fd+i8WAi6mUI X-Received: by 2002:a17:902:8d91:: with SMTP id v17mr27920203plo.91.1562628428970; Mon, 08 Jul 2019 16:27:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562628428; cv=none; d=google.com; s=arc-20160816; b=f/NaZyI+No/QS2TiEwi75DzHfUIKxGfVKowEuuJeUGTbiPKrVLLPmeYZyUPOau/vw1 S8c4QMj9wY0wdUv5pGpCJAlVIy+CzzspDJwwNE6Uxgqes24zOsBJ3ExV4WpLrjLKIjGv pQhAQHG9vo6bySt20RqkEirEq5/jcTVQHP13QsTkakd+woehpstWNXT8zeuWM4TG4Jda nlrDQFsmKMyfkeBtYR9AIGA8QDt1CznrspsWZMkEmNqvyrZ3qXobjh491El4YVVNNt9y gFArg0nunM2QcJU0H54oBBkS2SSPP10/AcXX3TWJxPL13YtTMmtKu+yb5itop+S9DIFm CU4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=TEslUgTxDoTmgVFkw/Gdz90MIdtjEdl0ELZ0iqj8/xc=; b=cneJ7U87K15PM84gcDifMzSQf6PIp26WzBBNivWtmxlxNxCAR8LXeU/ftSGLgZFjDT QfE+9kCSap+FM28Qe4zqeq9o5WiODBviwXW2eGEmkfvaSkUznnmpRAULcrfMXfz2oC6A 26e/rt2ur9bmzMiu3dDtzf4kw27gCGb19olw6Em4lMuzpsWPQKMngWZo0z2By8vJNGXF VxIvdI7sKhO736OzL1racsf2W26TdMLU2uD0w0xPv7JYEveOCqZ7uCsq3u4vIxiOg790 QLV+at9DvYgzFXO5BNdB820I53uV5K0osI222BvvIg6uSpaUs4DmFaDSr0raIeTsfeJp +Hhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j66si18322703plb.375.2019.07.08.16.26.54; Mon, 08 Jul 2019 16:27:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405135AbfGHVLh (ORCPT + 99 others); Mon, 8 Jul 2019 17:11:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40974 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727011AbfGHVLh (ORCPT ); Mon, 8 Jul 2019 17:11:37 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 28D923082A9C; Mon, 8 Jul 2019 21:11:37 +0000 (UTC) Received: from laptop.jcline.org (ovpn-120-32.rdu2.redhat.com [10.10.120.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC6B15D9E5; Mon, 8 Jul 2019 21:11:36 +0000 (UTC) Received: from laptop.jcline.org.com (localhost [IPv6:::1]) by laptop.jcline.org (Postfix) with ESMTP id 1BD637045B1C; Mon, 8 Jul 2019 17:11:36 -0400 (EDT) From: Jeremy Cline To: Linus Walleij , Bartosz Golaszewski , Jonathan Corbet Cc: linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jeremy Cline Subject: [PATCH] Documentation: gpio: fix function links in the HTML docs Date: Mon, 8 Jul 2019 17:11:23 -0400 Message-Id: <20190708211123.16495-1-jcline@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 08 Jul 2019 21:11:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The shorthand [_data] and [devm_] cause the HTML documentation to not link to the function documentation properly. This expands the references to the complete function names with the exception of devm_gpiochip_remove() which was dropped by commit 48207d7595d2 ("gpio: drop devm_gpiochip_remove()"). Signed-off-by: Jeremy Cline --- Documentation/driver-api/gpio/driver.rst | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Documentation/driver-api/gpio/driver.rst b/Documentation/driver-api/gpio/driver.rst index 1ce7fcd0f989..d4197ea3dafb 100644 --- a/Documentation/driver-api/gpio/driver.rst +++ b/Documentation/driver-api/gpio/driver.rst @@ -69,9 +69,9 @@ driver code: The code implementing a gpio_chip should support multiple instances of the controller, preferably using the driver model. That code will configure each -gpio_chip and issue ``gpiochip_add[_data]()`` or ``devm_gpiochip_add_data()``. -Removing a GPIO controller should be rare; use ``[devm_]gpiochip_remove()`` -when it is unavoidable. +gpio_chip and issue gpiochip_add(), gpiochip_add_data(), or +devm_gpiochip_add_data(). Removing a GPIO controller should be rare; use +gpiochip_remove() when it is unavoidable. Often a gpio_chip is part of an instance-specific structure with states not exposed by the GPIO interfaces, such as addressing, power management, and more. @@ -418,11 +418,11 @@ symbol: If there is a need to exclude certain GPIO lines from the IRQ domain handled by these helpers, we can set .irq.need_valid_mask of the gpiochip before -[devm_]gpiochip_add_data() is called. This allocates an .irq.valid_mask with as -many bits set as there are GPIO lines in the chip, each bit representing line -0..n-1. Drivers can exclude GPIO lines by clearing bits from this mask. The mask -must be filled in before gpiochip_irqchip_add() or gpiochip_irqchip_add_nested() -is called. +devm_gpiochip_add_data() or gpiochip_add_data() is called. This allocates an +.irq.valid_mask with as many bits set as there are GPIO lines in the chip, each +bit representing line 0..n-1. Drivers can exclude GPIO lines by clearing bits +from this mask. The mask must be filled in before gpiochip_irqchip_add() or +gpiochip_irqchip_add_nested() is called. To use the helpers please keep the following in mind: -- 2.21.0