Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 8 Jul 2019 16:47:43 -0700
From:   Jaegeuk Kim <jaegeuk@kernel.org>
To:     Chao Yu <yuchao0@huawei.com>
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, chao@kernel.org,
        Park Ju Hyung <qkrwngud825@gmail.com>
Subject: Re: [PATCH] f2fs: improve print log in f2fs_sanity_check_ckpt()
Message-ID: <20190708234743.GC21769@jaegeuk-macbookpro.roam.corp.google.com>
References: <20190708062912.104815-1-yuchao0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190708062912.104815-1-yuchao0@huawei.com>
User-Agent: Mutt/1.8.2 (2017-04-18)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/08, Chao Yu wrote:
> As Park Ju Hyung suggested:
> 
> "I'd like to suggest to write down an actual version of f2fs-tools
> here as we've seen older versions of fsck doing even more damage
> and the users might not have the latest f2fs-tools installed."
> 
> This patch give a more detailed info of how we fix such corruption
> to user to avoid damageable repair with low version fsck.
> 
> Signed-off-by: Park Ju Hyung <qkrwngud825@gmail.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>  fs/f2fs/super.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 019422a0844c..3cd6c8d810f9 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2737,7 +2737,8 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
>  
>  	if (__is_set_ckpt_flags(ckpt, CP_LARGE_NAT_BITMAP_FLAG) &&
>  		le32_to_cpu(ckpt->checksum_offset) != CP_MIN_CHKSUM_OFFSET) {
> -		f2fs_warn(sbi, "layout of large_nat_bitmap is deprecated, run fsck to repair, chksum_offset: %u",
> +		f2fs_warn(sbi, "using deprecated layout of large_nat_bitmap, "
> +			  "please run fsck v1.13.0 or higher to repair, chksum_offset: %u",

How about adding the patch name as well?

>  			  le32_to_cpu(ckpt->checksum_offset));
>  		return 1;
>  	}
> -- 
> 2.18.0.rc1